Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise correct errors from mocking.py #71

Closed
5 tasks done
PietroPasotti opened this issue Oct 20, 2023 · 1 comment
Closed
5 tasks done

Raise correct errors from mocking.py #71

PietroPasotti opened this issue Oct 20, 2023 · 1 comment

Comments

@PietroPasotti
Copy link
Collaborator

PietroPasotti commented Oct 20, 2023 •
edited
Loading

Many mocking.py calls raise incorrect errors instead of what ops would raise.
Charm code expecting specific errors may as a result break.
juditnovak added a commit to canonical/mysql-router-operator that referenced this issue Oct 23, 2023
@juditnovak
Juju3 as default + ops-scenario fixed (canonical/ops-scenario#71)
ce13b0b
juditnovak added a commit to canonical/mysql-router-operator that referenced this issue Oct 24, 2023
@juditnovak
Juju3 as default + ops-scenario fixed (canonical/ops-scenario#71)
1f91e08
juditnovak added a commit to canonical/mysql-router-operator that referenced this issue Oct 24, 2023
@juditnovak
Juju3 as default + ops-scenario fixed (canonical/ops-scenario#71)
3ab0db3
juditnovak added a commit to canonical/mysql-router-operator that referenced this issue Oct 25, 2023
@juditnovak
Juju3 as default + ops-scenario fixed (canonical/ops-scenario#71)
6b210bf
@PietroPasotti
Copy link
Collaborator Author

fixed by #72

juditnovak added a commit to canonical/mysql-router-operator that referenced this issue Oct 26, 2023
@juditnovak
Juju3 as default + ops-scenario fixed (canonical/ops-scenario#71)
fd3b13d
juditnovak added a commit to canonical/mysql-router-operator that referenced this issue Oct 26, 2023
@juditnovak
Juju3 as default + ops-scenario fixed (canonical/ops-scenario#71)
6c6aade
juditnovak added a commit to canonical/mysql-router-operator that referenced this issue Oct 30, 2023
@juditnovak
Juju3 as default + ops-scenario fixed (canonical/ops-scenario#71)
0996f54
juditnovak added a commit to canonical/mysql-router-operator that referenced this issue Oct 30, 2023
@juditnovak
Juju3 as default + ops-scenario fixed (canonical/ops-scenario#71)
1fb9c00
juditnovak added a commit to canonical/mysql-router-operator that referenced this issue Oct 30, 2023
@juditnovak
Juju3 as default + ops-scenario fixed (canonical/ops-scenario#71)
70400cf
juditnovak added a commit to canonical/mysql-router-operator that referenced this issue Oct 30, 2023
@juditnovak
Juju3 as default + ops-scenario fixed (canonical/ops-scenario#71)
ea1fd72
juditnovak added a commit to canonical/mysql-router-operator that referenced this issue Oct 31, 2023
@juditnovak
Juju3 as default + ops-scenario fixed (canonical/ops-scenario#71)
fec7b87
juditnovak added a commit to canonical/mysql-router-operator that referenced this issue Oct 31, 2023
@juditnovak
Juju3 as default + ops-scenario fixed (canonical/ops-scenario#71)
580bd8f
juditnovak added a commit to canonical/mysql-router-operator that referenced this issue Nov 1, 2023
@juditnovak
Juju3 as default + ops-scenario fixed (canonical/ops-scenario#71)
07df5d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PietroPasotti