SecretNotFoundError should be raised when a secret is not found #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PietroPasotti
approved these changes
Oct 20, 2023
juditnovak
force-pushed
the
bugfix/secret_not_found_instead_of_runtime_error
branch
from
3b114d3 to
dcb7ee6
Compare
PietroPasotti
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highly misleading, currently a different exception is raised by
scenariothan byops, when a secret doesn't exist.This is cirtical to testing our code, where we need to perform specific actions when a secret is not found, and continue running actions instead of breaking the execution flow