From b0df183955b8077cfead00d581c3903de1fbb37d Mon Sep 17 00:00:00 2001
From: Fred Lotter <fred.lotter@canonical.com>
Date: Tue, 6 Aug 2024 08:32:52 +0200
Subject: [PATCH] Review improvements 1

---
 internals/overlord/overlord.go | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/internals/overlord/overlord.go b/internals/overlord/overlord.go
index fecb1fc2..0fe96a16 100644
--- a/internals/overlord/overlord.go
+++ b/internals/overlord/overlord.go
@@ -371,7 +371,7 @@ func (o *Overlord) Loop() {
 			}
 		}
 	})
-	o.ensureWaitRun()
+	o.waitEnsureRun()
 }
 
 func (o *Overlord) ensureDidRun() {
@@ -383,22 +383,22 @@ func (o *Overlord) ensureDidRun() {
 	}
 }
 
-// ensureWaitRun waits until StateEngine.Ensure() was called at least once.
-func (o *Overlord) ensureWaitRun() {
+// waitEnsureRun waits until StateEngine.Ensure() was called at least once.
+func (o *Overlord) waitEnsureRun() {
 	select {
 	case <-o.ensureRun:
 	case <-o.loopTomb.Dying():
 	}
 }
 
-func (o *Overlord) CanStandby() (ensured bool) {
+func (o *Overlord) CanStandby() bool {
 	select {
 	case <-o.ensureRun:
 		// Already closed. Ensure already ran at least once.
-		ensured = true
+		return true
 	default:
+		return false
 	}
-	return ensured
 }
 
 // Stop stops the ensure loop and the managers under the StateEngine.