Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yaml linting #481

Closed
wants to merge 1 commit into from
Closed

Add yaml linting #481

wants to merge 1 commit into from

Conversation

sed-i
Copy link
Contributor

@sed-i sed-i commented May 8, 2023

Issue

YAML files aren't linted.

Solution

Lint YAML files.

Context

Using yamllint may be obviated when:

Testing Instructions

Release Notes

Add yaml linting.

@sed-i
Copy link
Contributor Author

sed-i commented May 8, 2023

Seems like this could be an argument in favor of a custom "generic o11y charm" pre-commit hook: instead of opening PRs on all repos, could have added yamllint just in one place.

@sed-i
Copy link
Contributor Author

sed-i commented Aug 29, 2023

#21 and #22 already capture all we need. Closing.

@sed-i sed-i closed this Aug 29, 2023
@sed-i sed-i deleted the feature/yamllint branch August 29, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant