Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check all users for valid authorization comment #925

Open
yanksyoon opened this issue Feb 21, 2024 · 0 comments
Open

Check all users for valid authorization comment #925

yanksyoon opened this issue Feb 21, 2024 · 0 comments

Comments

@yanksyoon
Copy link
Contributor

This is a follow-up issue to the comment

Perhaps for a follow up PR, it still looks like we need to get full results for the push logins since that is used to authorize the comment for approving a run for an external fork. In that case we probably do need to retrieve all push logins since we have to compare the set of users that commented the authorization string to the set of allowed users in which case it would be expensive to check each one individually. In most cases I would expect there only to be 1 valid authorization comment but probably better for us to handle the case where there are a lot

Since there can be multiple users that can authorize the workflow run, it is required to fetch all users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant