Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove defer #76

Merged
merged 7 commits into from
Feb 20, 2024
Merged

feat: Remove defer #76

merged 7 commits into from
Feb 20, 2024

Conversation

markbeierl
Copy link

Description

Removes explicit certificate relations and defer events

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
    I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
    Any dependent changes have been merged and published in downstream modules
    I have bumped the version of the library

Mark Beierl added 2 commits February 14, 2024 15:28
Removes explicit certificate relations and defer events
@markbeierl markbeierl requested a review from a team as a code owner February 14, 2024 20:39
@markbeierl markbeierl changed the title Telco 889 remove defer feat: Remove defer Feb 14, 2024
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
Co-authored-by: Gulsum Atici <[email protected]>
src/charm.py Outdated Show resolved Hide resolved
Copy link
Contributor

@gatici gatici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The branch needs to be rebased.

@markbeierl markbeierl merged commit 3e9a177 into main Feb 20, 2024
12 checks passed
@markbeierl markbeierl deleted the TELCO-889_remove-defer branch February 20, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants