Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert many: fix swapping back and forth between kernels with components during remodeling #15139

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

ernestl
Copy link
Collaborator

@ernestl ernestl commented Feb 26, 2025

Reverts #15046

After discussion with Andrew P, we decided to rather revert and create replacement PR that shows clean nested test run.
This content is not critical for the 2.68.2 release and it will therefore be excluded.

@ernestl ernestl changed the title Revert "many: fix swapping back and forth between kernels with components during remodeling" revert many: fix swapping back and forth between kernels with components during remodeling Feb 26, 2025
Copy link
Member

@andrewphelpsj andrewphelpsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ernestl ernestl added the Skip spread Indicate that spread job should not run label Feb 26, 2025
@ernestl ernestl closed this Feb 26, 2025
@ernestl ernestl reopened this Feb 26, 2025
Copy link

github-actions bot commented Feb 26, 2025

Wed Feb 26 20:25:49 UTC 2025

Spread tests skipped

Copy link
Member

@alfonsosanchezbeato alfonsosanchezbeato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@ernestl ernestl merged commit fcdca09 into master Feb 26, 2025
58 of 76 checks passed
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 90.76923% with 6 lines in your changes missing coverage. Please review.

Project coverage is 78.06%. Comparing base (a272aac) to head (7addbce).
Report is 70 commits behind head on master.

Files with missing lines Patch % Lines
overlord/snapstate/snapstate.go 90.76% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #15139      +/-   ##
==========================================
- Coverage   78.07%   78.06%   -0.01%     
==========================================
  Files        1182     1185       +3     
  Lines      157743   158244     +501     
==========================================
+ Hits       123154   123534     +380     
- Misses      26943    27029      +86     
- Partials     7646     7681      +35     
Flag Coverage Δ
unittests 78.06% <90.76%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip spread Indicate that spread job should not run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants