Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zsh: mcfly incorrectly parses multi-line zhistory entries #87

Open
durin42 opened this issue Jul 1, 2020 · 5 comments
Open

zsh: mcfly incorrectly parses multi-line zhistory entries #87

durin42 opened this issue Jul 1, 2020 · 5 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@durin42
Copy link

durin42 commented Jul 1, 2020

if you have a command typed as

echo foo \
  bar

that ends up as separate entries in mcfly, rather than a single one. It looks like mcfly is incorrectly parses the history entry? The relevant snippet for that from my .zsh_history is:

: 1593624164:0;echo foo \\
 bar

It looks like mcfly is getting confused by this, and I think it only gets the last line of the command.

@cantino cantino added the bug Something isn't working label Jul 4, 2020
@cantino
Copy link
Owner

cantino commented Jul 4, 2020

Thanks @durin42, I think that is a bug.

@cantino cantino added good first issue Good for newcomers help wanted Extra attention is needed labels Jul 4, 2020
@dithpri
Copy link

dithpri commented Apr 14, 2022

I'm experiencing the same issue

@lucidyan
Copy link

lucidyan commented Aug 1, 2022

Same problem here, in my case mcfly became unusable for most cases because I have to use history | grep every time it appears.

@magnetophon
Copy link

Any news on this?

@cantino
Copy link
Owner

cantino commented Mar 19, 2023

It hasn't been a priority for me since I don't use many multi-line commands, but I'm open to pull requests. #162 was a first attempt but someone needs to own it and test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants