switch to Postgres.js?

[sjvans]

Postgres.js claims to be the fastest postgres client. See benchmarks.

Should we switch?

[gregorwolf]

I think we should wait a bit until the user base of Postgres.js grows:

[gregorwolf]

Is the public domain license an issue?

[vobu]

oooooh, I think we might even want to look at https://github.com/electric-sql/pglite 👀 (once parametrised queries are supported)

[sjvans]

oooooh, I think we might even want to look at https://github.com/electric-sql/pglite 👀 (once parametrised queries are supported)

I think these are parallel activities though, as you wouldn’t necessarily use pglite in production

[BobdenOs]

While it is possible to provide support for multiple drivers. It comes with quite some maintenance overhead. Especially for Postgres as it does not support some required scenarios on its network protocol. For @cap-js/hana it provides support for both hana-client and hdb. So the same model could be added into the Postgres Service.

The main feature to consider is streaming. As for the current implementation there is bi-direction streaming (in, out). These two implementations both hijack the underlying tcp connection and cannot be beaten by any other implementation. Unless they implement a more efficient tcp implementation then nodejs currently provides.

Especially when looking at the performance the current implementation can reach vs using the driver alone.

const dataset = new Array(1 << 8).fill('').map((_, i) => [i, i + ''])
// 256rows (231.8066999912262ms)
await cds.tx(async tx => {
  await tx.run(`INSERT INTO ${Books.name.replace(/\./g, '_')} (ID, title) values ($1,$2)`, dataset)
})

const entries = dataset.map(r => ({ ID: r[0], title: r[1] }))
// 256rows (24.753600001335144ms) 
await INSERT(entries).into(Books)