feat: deep UPDATE without reading
#866
Conversation
BobdenOs
requested review from
danjoa,
johannes-vogel,
stewsk,
patricebender,
sjvans and
David-Kunz
as code owners
…ep-without-read
BobdenOs
requested review from
gregorwolf,
sebastianesch and
vobu
as code owners
| @@ -214,7 +214,7 @@ class SQLService extends DatabaseService { | |||
| // REVISIT: It's not yet 100 % clear under which circumstances we can rely on db constraints | |||
| return (super.onDELETE = /* cds.env.features.assert_integrity === 'db' ? this.onSIMPLE : */ deep_delete) | |||
| async function deep_delete(/** @type {Request} */ req) { | |||
| let { compositions } = req.target | |||
| let { compositions } = (req.target ??= req.query.target) | |||
There was a problem hiding this comment.
when is this not set? /cap/cds/blob/402a114f8968c2bc25c5f1e2de2208f4cac0c66d/lib/srv/srv-dispatch.js#L29
| @@ -750,7 +751,7 @@ class CQN2SQLRenderer { | |||
| const managed = this._managed.slice(0, columns.length) | |||
|
|
|||
| const extractkeys = managed | |||
| .filter(c => keys.includes(c.name)) | |||
| // .filter(c => keys.includes(c.name)) | |||
| if (val[val.length - 1] === ',') val = arg.json = val.slice(0, -1) + ']' | ||
| if (val[val.length - 1] === '[') val = arg.json = val + ']' |
There was a problem hiding this comment.
| if (val[val.length - 1] === ',') val = arg.json = val.slice(0, -1) + ']' | |
| if (val[val.length - 1] === '[') val = arg.json = val + ']' | |
| if (val.at(-1) === ',') val = arg.json = val.slice(0, -1) + ']' | |
| if (val.at(-1) === '[') val = arg.json = val + ']' |
| -- DEBUG => this.dbc._native.prepare(cds.utils.fs.readFileSync(__dirname + '/deep-genres.sql','utf-8')).exec([JSON.stringify(query.UPDATE.data)]) | ||
| DO (IN JSON NCLOB => ?) BEGIN | ||
|
|
||
| -- Extract genres with a depth of 3 (like: '$.children[*].children[*]') |
There was a problem hiding this comment.
depth can be determined based on input json, right? we must just union all all provided rows
| ERROR ON ERROR | ||
| ) AS NEW; | ||
|
|
||
| -- DELETE all children of parents that are no longer in the dataset |
There was a problem hiding this comment.
where are rows deleted which are not children of parents, but which are not part of the dataset?
E.g.
JSON input:
| ID | parent_ID |
|---|---|
| 1 | null |
| 11 | 1 |
| 12 | 1 |
| 2 | null |
| 21 | 2 |
| 22 | 2 |
Existing data:
| ID | parent_ID | will be deleted? |
|---|---|---|
| 13 | 1 | yes |
| 3 | null | no |
There was a problem hiding this comment.
Note: They might be children of other entities and would not have to be deleted.
There was a problem hiding this comment.
Thinking about it again, we can exclude non-children entities since compositions, by definition, are children and one needs to consider only children and children's children of the root instance.
We should also look at the case of a composition of one where the foreign key is part of the parent. Here, one cannot identify the previous child purely based on the payload and one needs to take into account the foreign keys of existing data.
tests are currently failing only on
HXEeverything passed onHCE