Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Incorrect curly brace matching #63

Open
1 task done
hakimio opened this issue Sep 10, 2024 · 5 comments
Open
1 task done

[BUG] Incorrect curly brace matching #63

hakimio opened this issue Sep 10, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@hakimio
Copy link

hakimio commented Sep 10, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Curly brace is matched with type containing parenthesis:

image

Expected Behavior

Curly braces should be matched with curly braces

Steps To Reproduce

  1. Put the text cursor next to the curly brace in the following code:
entity UserRoleGroups : cuid {
    name        : String not null @mandatory;
    description : String(500);
}

Versions

Sap CDS Language Support: 1.1.0
Node.js: 20.13.1

OS / Environment

Windows

Repository Containing a Minimal Reproducible Example

No response

Anything else?

No response

@hakimio hakimio added the bug Something isn't working label Sep 10, 2024
@hakimio hakimio changed the title [BUG] Incorrect curly braces matching [BUG] Incorrect curly brace matching Sep 10, 2024
@manwithafox
Copy link

Reproduced in WebStorm/macOS with this even simpler example:

Screenshot 2024-09-10 at 12 48 07

Note, I have even separated the tokens String( 500 )

@manwithafox
Copy link

... works in VSCode

@tim-sh
Copy link
Member

tim-sh commented Sep 11, 2024

Hi @hakimio,
thanks for reporting.
In all likelihood, this is a bug in IntelliJ's TextMate module. I'll get back to you once the JetBrains issue is clarified.

@hakimio
Copy link
Author

hakimio commented Sep 11, 2024

@tim-sh can you share the JetBrains issue link?

@tim-sh
Copy link
Member

tim-sh commented Sep 11, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants