Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse types from cds-types #368

Open
daogrady opened this issue Oct 17, 2024 · 1 comment
Open

Reuse types from cds-types #368

daogrady opened this issue Oct 17, 2024 · 1 comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers improvement keepalive Will not be closed by Stale bot

Comments

@daogrady
Copy link
Contributor

Our type definitions used in the TSDoc are currently defined locally.
As @cap-js/cds-types is now a peer dependency, we could reuse all cds-related types from there. Especially the CSN flavours are good candidates for reuse.
@daogrady daogrady added documentation Improvements or additions to documentation good first issue Good for newcomers improvement labels Oct 17, 2024
@daogrady daogrady mentioned this issue Oct 17, 2024
Merged
@github-actions GitHub Actions
Copy link

This issue has not been updated in a while. If it is still relevant, please comment on it to keep it open. The issue will be closed soon if it remains inactive.

@github-actions github-actions bot added the stale label Nov 16, 2024
@daogrady daogrady added keepalive Will not be closed by Stale bot and removed stale labels Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers improvement keepalive Will not be closed by Stale bot
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@daogrady