Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create dedicated type for headers parameter in services.d.ts #13

Open
daogrady opened this issue Jan 8, 2024 · 0 comments
Open

Create dedicated type for headers parameter in services.d.ts #13

daogrady opened this issue Jan 8, 2024 · 0 comments

Comments

@daogrady
Copy link
Contributor

daogrady commented Jan 8, 2024

headers appears to be a recurring parameter type throughout the services definition. The expected type is related to general HTTP headers, although apparently has different format. The IncomingHttpHeaders type from node:http contains the definitions for regular HTTP headers. Reusing that type would give us a nice, strict typing, consistency (currently we have a mix of object and {}), and code completion:

Screenshot 2024-01-08 at 07 45 01

Originally posted by @daogrady in #9 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant