Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Properties In LinkedDefinition #43

Closed
1 task done
Michael-Galambos-AGI opened this issue Apr 11, 2024 · 3 comments
Closed
1 task done

Missing Properties In LinkedDefinition #43

Michael-Galambos-AGI opened this issue Apr 11, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@Michael-Galambos-AGI
Copy link

Michael-Galambos-AGI commented Apr 11, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

The type LinkedDefinition is missing multiple properties that exist in the debugger or the other way around.

For example:
associations is missing,

image
image

target is mendatory but doesnt exist,
image
image

or any ´´´annotations´´´ like @cds.external dont exist either.
image
image

Expected Behavior

the propertie associations to exsist, target to not be mendatory and properties for annotations to exist

References

The values either exsist in the debugger but arent documented or are documented wrong.

Versions

| @cap-js/cds-types | 0.2.0 |
| @cap-js/sqlite | 1.6.0 |
| @sap/cds | 7.8.0 |
| @sap/cds-compiler | 4.8.0 |
| @sap/cds-dk (global) | 7.8.1 |
| @sap/cds-fiori | 1.2.3 |
| @sap/cds-foss | 5.0.0 |
| @sap/cds-mtxs | 1.17.0 |
| @sap/eslint-plugin-cds | 2.6.7 |
| Node.js | v18.17.1 |

Anything else? Logs?

I thought i'd also mention it here that req.errors also doesnt exsist.

@Michael-Galambos-AGI Michael-Galambos-AGI added the bug Something isn't working label Apr 11, 2024
@Michael-Galambos-AGI Michael-Galambos-AGI changed the title [BUG] <Missing Properties In LinkedDefinition> Missing Properties In LinkedDefinition Apr 11, 2024
@Raphael-Gisler-AGI
Copy link

The "@cds.external" Tag and "associations" Tag look like they should be implemented as an optional field. If using "@cds.external" isn't the best practice way of figuring out whether or not a LinkedDefinition is external please let me know.

@daogrady
Copy link
Contributor

daogrady commented Aug 5, 2024

Hi @Michael-Galambos-AGI ,

the linked definitions have been exposed in the latest types for cds8. If you have had the chance to upgrade to cds8 yet, could you please check if this issue still persists? Thanks!

Best,
Daniel

@daogrady
Copy link
Contributor

I assume this is fixed in cds8. Feel free to reopen if the problem persists with the latest version of cds + cds-types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants