From 2eddca160bf2cdff1ba5d04fa19daa979db409f4 Mon Sep 17 00:00:00 2001
From: Johannes Vogel <johannes.vogel@sap.com>
Date: Mon, 22 Jan 2024 15:52:44 +0100
Subject: [PATCH] [wip]: tests + draft

---
 apis/cqn.d.ts                                | 7 +++++--
 test/typescript/apis/project/cds-ql.ts       | 1 +
 test/typescript/apis/project/cds-services.ts | 5 +++++
 3 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/apis/cqn.d.ts b/apis/cqn.d.ts
index 35bec7e5..f65a7b6d 100644
--- a/apis/cqn.d.ts
+++ b/apis/cqn.d.ts
@@ -1,8 +1,11 @@
-import { entity } from './csn' // cyclic dependency
+import { EntityElements, entity } from './csn' // cyclic dependency
 import { UnionToIntersection, UnionsToIntersections } from './internal/inference'
 
 // FIXME: a union type would be more appropriate here
-export type Query = Partial<SELECT & INSERT & UPDATE & DELETE & CREATE & DROP & UPSERT>
+// FIXME: This type is also used for req.query.
+//				It misses the QL functionality of req.query.
+//				It includes SELECT.elements for now but that should be expressed differently.
+export type Query = Partial< (SELECT & {elements: EntityElements}) & INSERT & UPDATE & DELETE & CREATE & DROP & UPSERT>
 
 export type SELECT = { SELECT: {
   distinct?: true,
diff --git a/test/typescript/apis/project/cds-ql.ts b/test/typescript/apis/project/cds-ql.ts
index ff88940d..11ae3e11 100644
--- a/test/typescript/apis/project/cds-ql.ts
+++ b/test/typescript/apis/project/cds-ql.ts
@@ -10,6 +10,7 @@ SELECT.from(Foos).columns("x") // x was suggested by code completion
 sel.from(Foos)
 sel.columns("x") // x was suggested by code completion
 sel.SELECT.columns?.filter(e => !e) // check if this is array
+sel.elements
 
 // ensure ql returns a proper CQN
 const s = SELECT.from(Foos).columns('ID').where('ID =', 42)
diff --git a/test/typescript/apis/project/cds-services.ts b/test/typescript/apis/project/cds-services.ts
index 2910693d..b99b9429 100644
--- a/test/typescript/apis/project/cds-services.ts
+++ b/test/typescript/apis/project/cds-services.ts
@@ -161,6 +161,11 @@ srv.before('*', async req => {
   req.tenant
   req.target.name
   req.entity
+
+  req.query
+  req.query.elements
+  // req.query.where('x =', 9)
+  (req.query as SELECT<Foo>).SELECT.from.ref
 })
 
 srv.after('*', (results, req) => {