Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust tests for revised log formatting in production #138

Merged
merged 3 commits into from
Nov 28, 2023

Conversation

sjvans
Copy link
Contributor

@sjvans sjvans commented Nov 22, 2023

No description provided.

@sjvans sjvans marked this pull request as ready for review November 27, 2023 08:20
@sjvans sjvans requested a review from a team as a code owner November 27, 2023 08:20
@sjvans sjvans requested a review from schwma November 27, 2023 08:21
@schwma
Copy link
Member

schwma commented Nov 27, 2023

The revised log formatting only affects production, right?

This entire test suite exists twice, once for prod (test/tests/error-handling-prod.test.js) and once for dev (test/tests/error-handling-prod.dev.js). The logging expects, however, currently only exist in the prod tests since they were thought to be the same for both scenarios.

Maybe it would be useful to also copy the original logging expects over to the dev test suite? I can also do that real quick if thats easier for you?

@sjvans
Copy link
Contributor Author

sjvans commented Nov 28, 2023

The revised log formatting only affects production, right?

right

This entire test suite exists twice, once for prod (test/tests/error-handling-prod.test.js) and once for dev (test/tests/error-handling-prod.dev.js). The logging expects, however, currently only exist in the prod tests since they were thought to be the same for both scenarios.

Maybe it would be useful to also copy the original logging expects over to the dev test suite? I can also do that real quick if thats easier for you?

👍

@sjvans sjvans merged commit 136d950 into main Nov 28, 2023
3 checks passed
@sjvans sjvans deleted the adjust-tests-for-revised-log-formatting-in-production branch November 28, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants