test: adopt @cap-js/sqlite #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobdenOs
reviewed
Feb 23, 2024
| const response = await POST('/graphql', { query }) | ||
| expect(response.data).toEqual({ data, errors }) | ||
| expect(response.data).toEqual({ data }) |
BobdenOs
approved these changes
Feb 23, 2024
| @@ -2,6 +2,9 @@ | |||
| "dependencies": { | |||
| "@cap-js/graphql": "*" | |||
| }, | |||
| "devDependencies": { | |||
| "@cap-js/sqlite": "*" | |||
There was a problem hiding this comment.
Are these added for the plugin detection ?
If that is the reason it would be better to run the test with CDS_CONFIG to allow for testing with not just @cap-js/sqlite.
There was a problem hiding this comment.
I don't want to introduce those internal flags also for open source modules.
In the meanwhile, I'd hope that there's no need anymore to switch back to the old implementation :)
| { | ||
| name: 'Edgar Allen Poe', | ||
| books: { | ||
| totalCount: null, // REVISIT: expected 2 |
There was a problem hiding this comment.
the totalCount is probably being returned as [email protected]. As defined here
There was a problem hiding this comment.
I'll add a BLI for us. Seems very "odata'ish" :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REVISIT:
→ The functions are implemented after OData v4.01 standard which specify them as case sensitive.
→ f74062f it's supported by @cap-js/sqlite