improved checkout technique

cap-js · Nov 7, 2024 · 0639ab9 · 0639ab9
1 parent f582259
commit 0639ab9
Show file tree

Hide file tree

Showing 7 changed files with 17 additions and 12 deletions.
diff --git a/.github/workflows/checkout b/.github/workflows/checkout
@@ -1,7 +1,7 @@
 #!/usr/bin/env node
 
 const cds = require("@sap/cds")
-const { read, write, append=_append } = cds.utils
+const { copy, read, write, append=_append } = cds.utils
 
 const checkout = {
 
@@ -15,7 +15,13 @@ const checkout = {
   },
 
   async messaging () {
-    await append ('\n'+`using from './incidents/field'; //> adds email fields to UI`+'\n') .to ('app/services.cds')
+    // copy content from xmpls/messaging to incidents...
+    for (let each of ['app','srv'])
+      copy('xmpls/messaging/'+each).to(each)
+    // add email fields to UI
+    await append ('\n'+`using from './incidents/field';`+'\n')
+      .to ('app/services.cds')
+    // enhance package.json
     let xmpls = await read ('xmpls/messaging/package.json')
     let base = await read ('package.json')
     for (let each of ['API_BUSINESS_PARTNER','messaging'])

diff --git a/xmpls/messaging/package.json b/xmpls/messaging/package.json
@@ -98,10 +98,10 @@
             "messaging": {
                 "kind": "local-messaging",
                 "[production]": {
-                  "kind": "enterprise-messaging-shared",
-                  "format": "cloudevents"
+                    "kind": "enterprise-messaging-shared",
+                    "format": "cloudevents"
                 }
-              }
+            }
         }
     }
 }
diff --git a/xmpls/messaging/services.cds b/xmpls/messaging/services.cds
@@ -0,0 +1,3 @@
+// Using local service implementation
+using { ProcessorService } from '../../app/services';
+annotate ProcessorService with @impl: 'srv/services.js';
diff --git a/xmpls/messaging/srv/mashup.cds b/xmpls/messaging/srv/mashup.cds
@@ -1,8 +1,4 @@
 // REVISIT: This file and all in ./external is copy from ../remote-service -> should be refactored
-
-using { ProcessorService } from '../../../app/services';
-annotate ProcessorService with @impl: 'srv/services.js';
-
 // REVISIT: This is not in line with our best practices.
 using { API_BUSINESS_PARTNER as S4 } from './external/API_BUSINESS_PARTNER';
 service RemoteService {

diff --git a/xmpls/messaging/req.http → xmpls/messaging/test/req.http b/xmpls/messaging/req.http → xmpls/messaging/test/req.http
diff --git a/xmpls/remote-service/services.cds b/xmpls/remote-service/services.cds
@@ -0,0 +1,3 @@
+// Using local service implementation
+using { ProcessorService } from '../../app/services';
+annotate ProcessorService with @impl: 'srv/services.js';
diff --git a/xmpls/remote-service/srv/mashup.cds b/xmpls/remote-service/srv/mashup.cds
@@ -1,6 +1,3 @@
-using { ProcessorService } from '../../../app/services';
-annotate ProcessorService with @impl: 'srv/services.js';
-
 // REVISIT: This is not in line with our best practices.
 using { API_BUSINESS_PARTNER as S4 } from './external/API_BUSINESS_PARTNER';
 service RemoteService {