Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mypy type hints #368

Open
stephenpardy opened this issue Jun 20, 2023 · 0 comments
Open

Add mypy type hints #368

stephenpardy opened this issue Jun 20, 2023 · 0 comments
Labels
development Issues that require technical work. Associated PRs are required. enhancement Issues & PRs that capture enhancements to existing features. Issues require associated PRs.

Comments

@stephenpardy
Copy link
Contributor

Is your enhancement request related to a problem? Please describe
Currently, Rubicon does not have added mypy type hints which makes type-checking modules that use Rubicon to be less robust.

Describe the solution you'd like
Add consistent type hints throughout the Rubicon package, starting with any user-facing functions and classes.

Describe alternatives you've considered
Business as usual.

Additional context
Type hints will also allow us to add type checks during the CI/CD process that can catch errors.
@stephenpardy stephenpardy added enhancement Issues & PRs that capture enhancements to existing features. Issues require associated PRs. development Issues that require technical work. Associated PRs are required. needs triage Issues that need to be prioritized by the core maintainers and added to a project board. labels Jun 20, 2023
@stephenpardy stephenpardy mentioned this issue Sep 10, 2023
Merged
@ryanSoley ryanSoley removed the needs triage Issues that need to be prioritized by the core maintainers and added to a project board. label Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
development Issues that require technical work. Associated PRs are required. enhancement Issues & PRs that capture enhancements to existing features. Issues require associated PRs.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stephenpardy @ryanSoley