Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gc-cli adds whitespace to files already in common-js format #16

Open
ProggerPete opened this issue Aug 3, 2017 · 2 comments
Open

gc-cli adds whitespace to files already in common-js format #16

ProggerPete opened this issue Aug 3, 2017 · 2 comments

Comments

@ProggerPete
Copy link

Ideally if no real changes were made by gc-cli on a file it would be unchanged.

@ProggerPete
Copy link
Author

Perhaps you could add a flag that checks to see if there is a 'module.exports =' in the file (that's not a comment) and just skips those files? I find myself reverting 98% of the files converted because none of the changes are neccessary and I don't want to add unrequired differences between our implementation and the reference implementation.

@briandipalma
Copy link
Collaborator

Hi Pete, thanks for raising the issue. Reinstall the latest I removed any formatting support as prettier makes this stuff redundant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants