Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: automated browser test on browserstack #553

Closed
wants to merge 18 commits into from
Closed

Conversation

dxphilo
Copy link
Contributor

@dxphilo dxphilo commented Mar 9, 2022

No description provided.

@dxphilo dxphilo requested a review from chrispanag March 9, 2022 08:19
@dxphilo
Copy link
Contributor Author

dxphilo commented Mar 9, 2022

@chrispanag you will need to enter the BrowserStack keys as github secrets for the automated test.

      username: ${{secrets.BROWSERSTACK_USERNAME}}
      access-key: ${{secrets.BROWSERSTACK_ACCESS_KEY}}

@chrispanag
Copy link
Contributor

@developerphilo can you describe exactly how the tests work here, what happens exactly and what are we testing?

I see two jobs that are doing the same thing (?) pull_request/push

@chrispanag chrispanag linked an issue Mar 9, 2022 that may be closed by this pull request
@dxphilo
Copy link
Contributor Author

dxphilo commented Mar 9, 2022

@developerphilo can you describe exactly how the tests work here, what happens exactly and what are we testing?

I see two jobs that are doing the same thing (?) pull_request/push

Browserstack action runs two jobs on push and on pull request but we can configure it to run once though the documentation suggest to run on both push and pull to have a clear depiction against every commit. "We recommend you to run on both push and pull_request so that you have a 1:1 build mapping against every commit".

The action will then invoke a tunnel connection(after grabbing the browserstack secret keys) between our environment and the BrowserStack device cloud. This will allow our app to be accessed by the browsers in the BrowserStack’s device cloud.

@chrispanag
Copy link
Contributor

chrispanag commented Mar 9, 2022

what are we testing exactly here?

Also what does the content of browserstack.js does?

@dxphilo
Copy link
Contributor Author

dxphilo commented Mar 9, 2022

what are we testing exactly here?

Also what does the content of browserstack.js does?

We are testing our application on the BrowserStack environment against the browsers in BrowserStack’s device cloud. Basically we are testing our app against various devices and browsers (versions) through BrowserStack.

browserstack.js is the test script hosting the various definitions regarding what browser/screens/version we want to test against. In this file we can declare various browser version and OS to performs our tests on.

@chrispanag
Copy link
Contributor

chrispanag commented Mar 9, 2022

We are testing our application on the BrowserStack environment against the browsers in BrowserStack’s device cloud. Basically we are testing our app against various devices and browsers (versions) through BrowserStack.

Yeah, I just meant, what are the success/fail conditions of our tests? Browserstack doesn't know what to test against (I think), or?

@dxphilo
Copy link
Contributor Author

dxphilo commented Mar 9, 2022

We are testing our application on the BrowserStack environment against the browsers in BrowserStack’s device cloud. Basically we are testing our app against various devices and browsers (versions) through BrowserStack.

Yeah, I just meant, what are the success/fail conditions of our tests? Browserstack doesn't know what to test against (I think), or?

We can pass in the browserstack.js various "capabilities" to test against.

@chrispanag
Copy link
Contributor

We are testing our application on the BrowserStack environment against the browsers in BrowserStack’s device cloud. Basically we are testing our app against various devices and browsers (versions) through BrowserStack.

Yeah, I just meant, what are the success/fail conditions of our tests? Browserstack doesn't know what to test against (I think), or?

We can pass in the browserstack.js various "capabilities" to test against.

As I see, these are just the environments that we'll use for testing. A testing scenario would be: the app initialises without errors or that the app is able to perform the X network requests etc.

chrispanag and others added 16 commits March 14, 2022 06:11
Co-authored-by: Christos Panagiotakopoulos <[email protected]>
* feat: started creating shareable links UI

* feat: add socials and direct link UI to share popup

* feat: add expandable blogchain link UI and loader to share popup

* style: darkmode and mobile adjustments

* feat: add share popup to reader layout

* feat: add basic backend functionality

* feat: add basic backend functionality

* style: add overflow ellipsis on links

* feat: add social media sharing

* feat: remove obsolete Share.vue component

Co-authored-by: Christos Panagiotakopoulos <[email protected]>
@chrispanag chrispanag closed this May 5, 2022
@ldmweb ldmweb deleted the feat/browserstack branch July 25, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create automated browser tests on BrowserStack
6 participants