Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eza: Issue with time-style flag #2631

Closed
2 of 12 tasks
mathomp4 opened this issue Dec 9, 2024 · 4 comments · Fixed by #2632
Closed
2 of 12 tasks

eza: Issue with time-style flag #2631

mathomp4 opened this issue Dec 9, 2024 · 4 comments · Fixed by #2632
Labels
bug Something isn't working darwin fund Fundable with polar.sh zsh

Comments

@mathomp4
Copy link

mathomp4 commented Dec 9, 2024

Current Behavior

When I try and tab-complete with eza with my preferred --time-style=long-iso option:

❯ eza --time-style=long-iso <tab>
invalid argument "long-iso" for "--time-style" flag: strconv.ParseBool: parsing "long-iso": invalid syntax

Expected Behavior

Tab completion should work.

Steps To Reproduce

  1. Try to tab complete: eza --time-style=long-iso

Version

1.1.0

OS

  • Darwin
  • Linux
  • Termux
  • Windows

Shell

  • Bash
  • Elvish
  • Fish
  • Nushell
  • Oil
  • Powershell
  • Xonsh
  • Zsh

Anything else?

No response

Polar

Fund with Polar
@mathomp4 mathomp4 added bug Something isn't working fund Fundable with polar.sh labels Dec 9, 2024
@mathomp4 mathomp4 changed the title eza: Issue with time-style flag eza: Issue with time-style=long-iso flag Dec 9, 2024
@mathomp4 mathomp4 changed the title eza: Issue with time-style=long-iso flag eza: Issue with time-style flag Dec 9, 2024
@mathomp4
Copy link
Author

mathomp4 commented Dec 9, 2024

Just did some tests and it looks like any --time-style flag might trigger the issue. Per the man page:

--time-style=STYLE
       How to format timestamps.  Valid timestamp styles are `default', `iso', `long-iso', 
       `full-iso', `relative', or a custom style `+<FORMAT>' (e.g.,
       `+%Y-%m-%d %H:%M' => `2023-09-30 13:00').

@rsteube
Copy link
Member

rsteube commented Dec 9, 2024

The --help output is missing the argument for some flags, so I got some wrong flag types when parsing it.
I fixed that and added completions, but seems I still got the flag type wrong for this one.

@mathomp4
Copy link
Author

mathomp4 commented Dec 9, 2024

@rsteube Thanks! I'll be on the lookout for v1.2 or v1.1.1 or whatever is next.

Luckily this is a flag I do not need so no big hinderance if it takes a while. It's just for prettifying. (Though I didn't know about the full-iso option and yikes! That be wiiiiide.)

@rsteube
Copy link
Member

rsteube commented Dec 9, 2024

You can try the nightly later: https://carapace-sh.github.io/carapace-bin/install/selfupdate.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working darwin fund Fundable with polar.sh zsh
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants