Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong ANSI color names #2641

Closed
2 of 12 tasks
munzirtaha opened this issue Dec 15, 2024 · 1 comment
Closed
2 of 12 tasks

Wrong ANSI color names #2641

munzirtaha opened this issue Dec 15, 2024 · 1 comment
Labels
bug Something isn't working fund Fundable with polar.sh linux nushell

Comments

@munzirtaha
Copy link
Contributor

munzirtaha commented Dec 15, 2024 •
edited by polar-sh bot
Loading

Current Behavior

The color names in pkg/actions/color/ansi.go are not following ANSI. If I am not missing something obvious, I will submit a PR

Expected Behavior

e.g. Instead of
"31", "Maroon", style.XTerm256Color(1),
It should be
"31", "Red", style.XTerm256Color(1),

Steps To Reproduce

No response

Version

v1.1.0

OS

  • Darwin
  • Linux
  • Termux
  • Windows

Shell

  • Bash
  • Elvish
  • Fish
  • Nushell
  • Oil
  • Powershell
  • Xonsh
  • Zsh

Anything else?

No response

Polar

Fund with Polar
@munzirtaha munzirtaha added bug Something isn't working fund Fundable with polar.sh labels Dec 15, 2024
@munzirtaha munzirtaha mentioned this issue Dec 15, 2024
Merged
@rsteube
Copy link
Member

rsteube commented Dec 15, 2024

fixed with #2642

@rsteube rsteube closed this as completed Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working fund Fundable with polar.sh linux nushell
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@munzirtaha @rsteube