Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2e-test-cleanup] Clean up e2e-storybook test for <c4d-feature-card> #12121

Open
m4olivei opened this issue Nov 25, 2024 · 1 comment
Open
Assignees
Labels
e2e-test-cleanup Effort to un-skip e2e tests for better coverage

Comments

@m4olivei
Copy link
Contributor

Description

This task is to update the e2e-storybook tests for the <c4d-feature-card> component to match the v2 specifications. Relevant links:

v2 Figma specifications
e2e-storybook test source code

At the completion of this task, there should be no tests in this components *.e2e.js file marked as skipped. The goal is that the existing tests are updated to be relevant for v2 specifications. In some cases, that might mean simple updates to match the markup structure, naming and style changes in v2. In other cases, tests may be irrelevant given the context of v2. There is some discretion involved. Where possible, document decisions made. Also take note of when and where Percy screenshot testing is covering components. If Percy tests are present for a given component and configuration, there may not be a need for further integration testing.

@bruno-amorim
Copy link
Contributor

bruno-amorim commented Nov 28, 2024

Hi @m4olivei
PR raised addressing this issue - #12130

Thanks!

kodiakhq bot pushed a commit that referenced this issue Dec 2, 2024
#12130)

… valid

### Related Ticket(s)

Closes # 
[/issues/12121](#12121)

### Description

The e2e-storybook tests have been failing for quite awhile. The tests do not appear to have been updated for v2. In many cases, the tests are using the old v1 prefixes.

The goal here is:

- Fix all skipped tests and align them with what we have in v2.

### Changelog

**New**

- Updated e2e-storybook for feature-card component so that all skipped tests are now running and correctly and doing the proper checkage
deathcave pushed a commit to deathcave/carbon-for-ibm-dotcom that referenced this issue Dec 4, 2024
carbon-design-system#12130)

… valid

### Related Ticket(s)

Closes # 
[carbon-design-system/issues/12121](carbon-design-system#12121)

### Description

The e2e-storybook tests have been failing for quite awhile. The tests do not appear to have been updated for v2. In many cases, the tests are using the old v1 prefixes.

The goal here is:

- Fix all skipped tests and align them with what we have in v2.

### Changelog

**New**

- Updated e2e-storybook for feature-card component so that all skipped tests are now running and correctly and doing the proper checkage
andy-blum pushed a commit that referenced this issue Dec 4, 2024
#12130)

… valid

### Related Ticket(s)

Closes # 
[/issues/12121](#12121)

### Description

The e2e-storybook tests have been failing for quite awhile. The tests do not appear to have been updated for v2. In many cases, the tests are using the old v1 prefixes.

The goal here is:

- Fix all skipped tests and align them with what we have in v2.

### Changelog

**New**

- Updated e2e-storybook for feature-card component so that all skipped tests are now running and correctly and doing the proper checkage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e-test-cleanup Effort to un-skip e2e tests for better coverage
Projects
Status: No status
Development

No branches or pull requests

2 participants