Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu and Menu buttons: storybook update 2 (popover) #3762

Closed
2 of 8 tasks
sstrubberg opened this issue Oct 3, 2023 · 7 comments
Closed
2 of 8 tasks

Menu and Menu buttons: storybook update 2 (popover) #3762

sstrubberg opened this issue Oct 3, 2023 · 7 comments

Comments

@sstrubberg
Copy link
Member

sstrubberg commented Oct 3, 2023

  • Direction There could be use cases where people want to place the menu button at the bottom. Could this add a prop to have the alignment upward? Similar to popover alignment
  • Alignment How do people align the button to the right of the menu in the code?

For each component:

  • New prop(s) for the alignment
  • New prop(s) for the direction
  • The actual changes to styles coming from these props (and also the new max-heights)
  • new stories and controls on the stories (directionality, etc. like popover)
  • VRT
  • maybe unit tests
@tay1orjones
Copy link
Member

We need a design spec for the alignment part before we can get started on this one.

@tay1orjones tay1orjones changed the title Menu and Menu buttons: storybook update 2 Menu and Menu buttons: storybook update 2 (popover) Oct 4, 2023
@thyhmdo
Copy link
Member

thyhmdo commented Oct 9, 2023

Alignment and positions:

Top: Top Full width, Left, and right
Bottom: Bottom Full width, Left, and right


Max height for menu

  • Menu for menu and combo button: Height is 5.5 items like the dropdown
  • Menu for overflow menu and context menu: The height of the user’s screen minus 32px. If it exceeds this, it should scroll.

NEED UPDATE (THIS SPEC IS OUT OF DATE)

@laurenmrice
Copy link
Member

Should this be in the carbon mono repo? @thyhmdo

@thyhmdo
Copy link
Member

thyhmdo commented Oct 16, 2023

I can move it

@thyhmdo
Copy link
Member

thyhmdo commented Oct 16, 2023

Design Specs issue carbon-design-system/carbon#14918

@tay1orjones
Copy link
Member

For the OverflowMenu changes we will probably need to put in a new sass feature flag for the styles since the same classnames are used in the new implementation behind the enable-v12-overflowmenu js feature flag.

@sstrubberg sstrubberg closed this as not planned Won't fix, can't repro, duplicate, stale Oct 31, 2023
@github-project-automation github-project-automation bot moved this from ⏱ Backlog to ✅ Done in Design System Oct 31, 2023
@sstrubberg
Copy link
Member Author

Closing in favor of the following three issues:

#3792
#3791
#3790

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants