Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(Data Table): Update AI Presence section image in Style tab #4366

Merged
merged 3 commits into from
Nov 20, 2024
Merged

docs(Data Table): Update AI Presence section image in Style tab #4366

merged 3 commits into from
Nov 20, 2024

Conversation

Kritvi-bhatia17
Copy link
Contributor

Closes #4324

This PR updates the image in the AI Presence section under the Data Table's Style tab. The updated image displays the complete data table generated by AI, excluding the in-line AI labels for individual data table cells.

Changelog

Changed

  • Updated the image in the AI Presence under the Data Table's Style tab.

@Kritvi-bhatia17 Kritvi-bhatia17 requested review from a team as code owners November 19, 2024 09:32
@vercel Vercel
Copy link

vercel bot commented Nov 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 5:06pm

alina-jacob
alina-jacob approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@alina-jacob alina-jacob left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

The vercel preview still shows the old image, but that could be a preview error, coz i can see the image is updated in the "Files changed" tab, so should be fine!
image

Good to go! 🚀

thyhmdo
thyhmdo approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@thyhmdo thyhmdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we've been having the issue with images :( hopefully, that'll go through once it's published!

@alisonjoseph alisonjoseph merged commit 8f65745 into carbon-design-system:main Nov 20, 2024
7 checks passed
@Kritvi-bhatia17 Kritvi-bhatia17 deleted the Data_structure_image branch November 20, 2024 19:02
@Kritvi-bhatia17
Copy link
Contributor Author

The vercel preview still shows the old image, but that could be a preview error, coz i can see the image is updated in the "Files changed" tab, so should be fine!

Yeah, we've been having the issue with images :( hopefully, that'll go through once it's published!

The image has been successfully updated after the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alina-jacob alina-jacob alina-jacob approved these changes

@thyhmdo thyhmdo thyhmdo approved these changes

@alisonjoseph alisonjoseph alisonjoseph approved these changes

@tay1orjones tay1orjones Awaiting requested review from tay1orjones tay1orjones is a code owner automatically assigned from carbon-design-system/developers-system-reviewers

@annawen1 annawen1 Awaiting requested review from annawen1 annawen1 is a code owner automatically assigned from carbon-design-system/developers-system-reviewers

Assignees
No one assigned
Labels
status: one more review 👀 status: ready for review 👀
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Data table] Style tab - AI Presence image has a bug
4 participants
@Kritvi-bhatia17 @alisonjoseph @thyhmdo @alina-jacob