Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a11y]: Form react examples may have some challenges #11650

Open
2 tasks done
mbgower opened this issue Jun 20, 2022 · 3 comments
Open
2 tasks done

[a11y]: Form react examples may have some challenges #11650

mbgower opened this issue Jun 20, 2022 · 3 comments

Comments

@mbgower
Copy link

mbgower commented Jun 20, 2022

Package

@carbon/react

Browser

Chrome

Operating System

MacOS

Package version

https://react.carbondesignsystem.com/?path=/story/components-form--default

React version

No response

Automated testing tool and ruleset

n/a

Assistive technology

No response

Description

The Form code examples are a little odd. There are a couple of considerations to capture:

  1. On the main form example, the focus indicator for a failure state on an input -- in this example, the password input -- will fail WCAG 2.2 (as proposed) since the red error outline is just turned blue to show focus. Nothing like 3:1 between the red and blue. I don't hate it. It just fails the requirement. Could be solved by thicker line on error focus, or a number of other ways.
    image

  2. I'm not entirely sure fieldset is used properly on the Formgroup code example.

  3. The label with tooltip is a little odd in its implementation, though maybe I wouldn't call it a failure. Space toggles the appearance off and on, unusual. It's also not requiring activation to show the tooltip, which I'm pretty sure is the implementation Toggletip ended up with

WCAG 2.1 Violation

As above Focus Appearance (from 2.2) and possibly 4.1.2 Parsing

Reproduction/example

Links provided in description

Steps to reproduce

For 1 above, press tab to reach password input in error, and note how only the color changes to indicator focus.

For 2, inspect element

For 3, open https://react.carbondesignsystem.com/?path=/story/components-formlabel--with-tooltip and press tab to reach the i information icon. Text will appear without the user activating the i icon.

Code of Conduct

@tay1orjones
Copy link
Member

the focus indicator for a failure state on an input ... Could be solved by thicker line on error focus, or a number of other ways.

@carbon-design-system/design what do you think we could do here for this case?

@aagonzales
Copy link
Member

aagonzales commented Jul 14, 2022

This is a fail in WCAG 2.2 which is not released yet (we currently only need to pass 2.1). We will do work for 2.2 updates in a future sprint/quarter. Not an immediate concern.

FYI @sstrubberg @tay1orjones @mbgower

@mbgower
Copy link
Author

mbgower commented Feb 24, 2023

@sstrubberg I don't think this warrants sev 2 at this point. Once WCAG 2.2 comes into force it will. It is on design radar.

@sstrubberg sstrubberg added severity: 4 https://ibm.biz/carbon-severity type: bug 🐛 and removed severity: 2 https://ibm.biz/carbon-severity labels Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ⏱ Backlog
Development

No branches or pull requests

4 participants