-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate examples off of Create React App #13637
Comments
It would be good if we actually made use of the examples directory in the root of the project. This was my first problem when I wanted to learn Carbon in the past: the documentation was outdated or in transition with the new v11, and I found many examples scattered everywhere, but didn't know where to start. Additionally, as a suggestion because of the new direction of CRA, I think it would be good to deprecate this template @carbon/cra-template |
The other thing to consider with this is now that we have the separate From my perspective we only need examples in the monorepo if we want them tied to the release process (lerna incrementing the versions of carbon deps used in the example) |
Examples
|
All tasks were validated and completed in this issue. |
Create React App project is moving in a new direction, and there are quite a few examples within the repo using it or
react-scripts
. I think it makes sense to move off of it to avoid future hassle with outdated dependencies and errant dependabot vulnerability errors.What should we move to?
We should consider the recommended options outlined by the new react docs. This is where the majority of new react-based projects will begin their journey with Carbon and we should have examples that follow suit. Two in particular stand out
Quite a few of the examples in the repo are old and outdated. In some cases they're using react-scripts v3 and causing errant dependabot vulnerability alerts. This includes the following directories:
Goals
Tasks
/examples/codesandbox
(reduce CRA usage) #14768/examples/codesandbox-with-sass-compilation
(reduce CRA usage) #14769The text was updated successfully, but these errors were encountered: