-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add native dialog
element support
#13807
Comments
Some considerations for the assessment:
In addition, for the non-modal version of the dialog, the following should be assessed, to discover potential issues meeting WCAG 2.2's Focus Not Obscured (Minimum) requirement as well as other existing requirements and conventions on focus handling, prior point of regard, focus indicators, etc. :
|
As part of #14156 @guidari and I tested the native dialog functionality as a potential fix but couldn't get the focus wrap behavior to work at all. I'm not sure if it's behind a flag for now or perhaps chrome/firefox hasn't implemented it yet fully? Either way I think we're blocked until we can confirm the new native dialog behavior functions as expected in all supported browsers. |
We'll also need to evaluate and document how other top layer elements interact with a
|
@tay1orjones it would appear that completely trapping focus is not desired. Tabbing to browser/environment controls is desirable, page content controls are blocked. |
Use of the the native dialog component https://codepen.io/lee-chase/pen/QWPbRLp/9c8c3f23b42a395dc519839e12f5d647 |
Unfortunately the transition behavior to |
Experimented and created this based on the native dialog. |
dialog
elementdialog
element support
I've updated this issue with continued direction now that the initial exploration has been merged in. Logical next step would be to refactor modal behind a feature flag to use
In #15926 we landed on not trying to polyfill this. Since it doesn't break anything other than the animation, we can consider it a case of progressive enhancement. It works in chrome/edge now and should work in safari this fall since it's already in the TP. Firefox users just won't see the animation until it's implemented there. |
Testing, VRT Might need design to weigh in: method by with we animate the modal in and out. |
Context
An initial exploration and delivery of a
Dialog
component was done a while ago:This experimental work was never exported or shown in storybook but still lives in the codebase. Most of the spec of that work stream was focused on managing focus and handling interactions such as escape closing the dialog.
The current state
Since then, there has been some progress on the native dialog element spec and much of this focus and interaction behavior is now provided natively by browsers.
Proposal
This issue is to propose considering using the native dialog element in place of the existing implementation that uses the
FocusScope
primitive.Depending on what we consider to be "must have" functionality of a
Dialog
, it might be that the bulk of the requirements might be met by thedialog
element. It might be a simple wrapper around that element is all we need.Pieces solved in #15926
Explore using native
Dialog
within the system<Dialog>
as experimental #18243The text was updated successfully, but these errors were encountered: