Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a11y]: ContainedList [usage examples] - content announced in one stretch #13950

Open
2 tasks done
andreancardona opened this issue Jun 7, 2023 · 5 comments
Open
2 tasks done

Comments

@andreancardona
Copy link
Contributor

andreancardona commented Jun 7, 2023

Package

@carbon/react

Browser

FF

Package version

carbon/[email protected]

Automated testing tool and ruleset

Manual QA

Assistive technology

JAWS FF

Description

JAWS announces the content in one stretch

When the focus goes to the mentioned text, JAWS is reading the content in one stretch.
Ex: List item List item details List item details

Note - Visually we can differentiate each item as 3 separate items but the screen reader is not

WCAG 2.1 Violation

1.3.2 Meaningful Sequence

Reproduction/example

Record Number 41 in the below table:
https://airtable.com/shrFsaeHhImOkuVNR

Steps to reproduce

When the visually separated text is announced together as one single element, The blind user would not realize that the text is visually separated. And also it makes SR over verbose which can be annoying.

Recommended fix

Screen reader is expected to identify the text separately how it is visible in each line

Code of Conduct

@andreancardona andreancardona added severity: 2 https://ibm.biz/carbon-severity type: a11y ♿ labels Jun 7, 2023
@andreancardona andreancardona moved this to ⏱ Backlog in Design System Jun 9, 2023
@andreancardona andreancardona added this to the 2023 Q3 milestone Jun 9, 2023
@andreancardona andreancardona changed the title [a11y]: ContainedList - Usage Examples [a11y]: ContainedList [usage examples] - JAWS announces the content in one stretch Jun 20, 2023
@andreancardona andreancardona changed the title [a11y]: ContainedList [usage examples] - JAWS announces the content in one stretch [a11y]: ContainedList [usage examples] - content announced in one stretch Jun 20, 2023
@andreancardona
Copy link
Contributor Author

andreancardona commented Jun 26, 2023

Chatted with @mbgower and the functionality / implementation of this component needs further refinement. Need to discuss with design & dev.

@sstrubberg we will be reviewing this in the next a11y guild call - fyi 💯

@andreancardona
Copy link
Contributor Author

andreancardona commented Jul 26, 2023

after talking to Gower here are some notes:

From our a11y call it seems: contained list is less read-only than a structured list. So although it looks closer to a plain old list, it is actually closer to an actionable data table, with structured list, despite its multiple columns, being a nearer kin to a list

From that perspective, it seems even more true to me that we should treat them as tables under the covers. The moment you do that, there is no more issue for JAWS users (with even minor experience) in regard to hearing too much information.

Also from Tom:

Certainly looks like a table to me

I'd think the title is the caption, and then the first column is the heading and the others are data cells

@tay1orjones
Copy link
Member

It looks like we're currently mixing native list elements with aria roles, which might be part of the problem. Based on this article, there's some differences in how list and list items are read when using native ul, ol, li, etc. vs using role="list" and role="listitem"

Right now ContainedList uses the native ul and li elements, but also places role="list" on the ul. If we remove the role="list" does it help screenreaders separate out the content based on what's focused?

Alternatively, if we keep the role="list", there isn't a role="listitem" on the li currently. If role="listitem" is added to the li's, does it help?

@sstrubberg sstrubberg moved this from 🪆 Needs Refined to ♿ Needs CAG in Design System Sep 6, 2023
@sstrubberg sstrubberg removed this from the 2023 Q3 milestone Sep 6, 2023
@dabrad26
Copy link
Member

Any update on this ticket? Or some of the other accessibility tickets that are opened? We have some gov customers reporting some concerns around some of these issues.

@mbgower
Copy link

mbgower commented Jul 24, 2024

@tay1orjones I did a quick check with JAWS on Edge, and the answer to these two questions appears to be "no"

Right now ContainedList uses the native ul and li elements, but also places role="list" on the ul. If we remove the role="list" does it help screenreaders separate out the content based on what's focused?

Alternatively, if we keep the role="list", there isn't a role="listitem" on the li currently. If role="listitem" is added to the li's, does it help?

@sstrubberg sstrubberg moved this from ♿ Needs a11y review to ⏱ Backlog in Design System Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ⏱ Backlog
Development

No branches or pull requests

5 participants