Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ComboBox] Autocomplete implementation #14007

Closed
Tracked by #6102
thyhmdo opened this issue Jun 15, 2023 · 6 comments · Fixed by #17268
Closed
Tracked by #6102

[ComboBox] Autocomplete implementation #14007

thyhmdo opened this issue Jun 15, 2023 · 6 comments · Fixed by #17268

Comments

@thyhmdo
Copy link
Member

thyhmdo commented Jun 15, 2023

Ref link for implementation #13903

Example: https://github.com/microsoft/fluentui/blob/master/packages/react/src/components/ComboBox/ComboBox.tsx
Repo for ComboBox https://github.com/microsoft/fluentui/blob/master/packages/react/src/components/ComboBox/ComboBox.tsx

This looks like it's not an easy update and going to take some time

@thyhmdo thyhmdo changed the title Autocomplete [ComboBox] Autocomplete Jun 15, 2023
@thyhmdo thyhmdo moved this to ⏱ Backlog in Design System Jun 15, 2023
@thyhmdo thyhmdo added this to Roadmap Jun 15, 2023
@github-project-automation github-project-automation bot moved this to Triage in Roadmap Jun 15, 2023
@sstrubberg sstrubberg moved this from Triage to Next in Roadmap Jun 15, 2023
@sstrubberg sstrubberg added this to the 2023 Q3 milestone Jun 15, 2023
@tay1orjones tay1orjones moved this from ⏱ Backlog to 🪆 Needs Refined in Design System Jun 15, 2023
@sstrubberg sstrubberg changed the title [ComboBox] Autocomplete [ComboBox] Autocomplete implementation Jun 27, 2023
@sstrubberg
Copy link
Member

sstrubberg commented Jun 27, 2023

Blocked by #13749

@sstrubberg sstrubberg moved this from 🪆 Needs Refined to ⏱ Backlog in Design System Jun 27, 2023
@sstrubberg sstrubberg moved this from Next to Now in Roadmap Aug 22, 2023
@tay1orjones
Copy link
Member

Might be blocked by needing to refactor ComboBox off of <Downshift/> and over to useCombobox.

@sstrubberg sstrubberg modified the milestones: 2023 Q3, 2023 Q4 Sep 19, 2023
@tay1orjones
Copy link
Member

After more discussion, the dev team feels that this is blocked by the refactor:

@tay1orjones
Copy link
Member

In addition to the existing behavior spec for this, we should consider the APG example for this that includes some nice functionality that uses the selection range

@tay1orjones tay1orjones modified the milestones: 2024 Q1, 2024 Q2 Apr 3, 2024
@tay1orjones
Copy link
Member

#14684 is complete

@thyhmdo thyhmdo moved this from ⏱ Backlog to 🚦 In Review in Design System May 29, 2024
@alisonjoseph alisonjoseph moved this from 🚦 In Review to ⏱ Backlog in Design System Jun 5, 2024
@riddhybansal riddhybansal removed their assignment Jun 5, 2024
@Gururajj77 Gururajj77 moved this from ⏱ Backlog to 🏗 In Progress in Design System Jun 6, 2024
@sstrubberg sstrubberg modified the milestones: 2024 Q2, 2024 Q3 Jun 27, 2024
@sstrubberg sstrubberg removed this from Roadmap Sep 16, 2024
@sstrubberg sstrubberg modified the milestones: 2024 Q3, 2024 Q4 Sep 16, 2024
@thyhmdo
Copy link
Member Author

thyhmdo commented Sep 18, 2024

In addition to the existing behavior spec for this, we should consider the APG example for this that includes some nice functionality that uses the selection range

Very similar to what Taylor referred here:

  • Click on the input
  • Start writing out the first letter
  • All options match the typed letter(s) will be filtered out
  • It highlights and spells out all the options
  • The first option (following the typed letters)
Screen.Recording.2024-09-18.at.9.22.18.AM.mov

@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in Design System Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment