-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[a11y]: The scrollable element <pre> with non-interactive content is not tabbable #14693
Comments
@zhanttbj In your reproduction link I don't see a "Review Deployment Options" button to be able to select the radio offering "Create from CLI" Could you reproduce the issue in a stackblitz instead, and post the link back here? |
Pls login first, then you can see the "Review Deployment Options" button |
@zhanttbj what version are you on? I am unable to reproduce the issue in the latest version of both v10 and v11 v10: https://v7-react.carbondesignsystem.com/?path=/story/components-codesnippet--singleline v11: https://react.carbondesignsystem.com/?path=/story/components-codesnippet--singleline I am able to tab to the code snippet and navigate to the right with the arrow key. Please ensure you are using the "single line" variant. |
@tw15egan here is the comments from dev, could you pls check and fix this issue if need? thanks I was able to apply the value change to type='single' and have the issue removed for the CodeSnippet inside the Create from CLI section. But the same issue persists for the type='multi' as well. Which is showing up for the same component under Work with code. I cannot use the single variant type for the Work with code one, since it needs to show more content as multiple lines of text. The carbon design team might need to change something for that as well since the same tag is present in there. |
Ahh I see, I have a simple fix that should resolve the issue 👍🏻 |
@tw15egan could we have this fix also in V10? as now our services are based on carbon V10, thanks |
@tw15egan sorry to trouble again, can we have this issue been fix as soon as possible? as this blocks our ACS process, thanks in advance. |
@tw15egan sorry, any progress on this issue? this is really block us Accessibility process, could you help on this as soon as possible, thanks in advance, |
Included as part of v10.59.16 |
@tw15egan Here is the latest comments from dev, could you help to check and response? thanks I tried implementing the latest version 10.59.16 but it doesn't seem to have been published to the artifactory. So I can't download the latest changes. I even tried to find the correct posted version for v10 but this is what I found as the result. Can you please ask the carbon team to investigate. |
Package
carbon-components
Browser
Chrome
Operating System
Windows
Package version
V10
React version
No response
Automated testing tool and ruleset
IBM Accessbility Checker
Assistive technology
No response
Description
===== DEFECT DESCRIPTION =====
Problem 1: The scrollable element
with non-interactive content is not tabbable
I also noticed another one in "Deploy with IBM Cloud Schematics" in the dropdown selectors which is using NestedFilterableDropdown from pal which also has a missing role prop.
=====STEPS TO REPRODUCE =====
Press the "Review Deployment Options" button and select the radio offering "Create from CLI" which will show the CodeSnippet with the accessibility issue which Flannan found.
===== EXPECTED RESULT =====
IBM 2.1.1 Keyboard
https://www.ibm.com/able/requirements/requirements/#2_1_1
This requirement ensures that content can be navigated with a keyboard or keyboard interface. When interactive content is operated using a keyboard, it is accessible to vision impaired people who cannot use devices requiring hand-eye coordination (e.g., a mouse) and by people who use alternative keyboards or input devices that act as keyboard emulators. Keyboard emulators include speech input, sip and puff devices, on-screen keyboards, scanning software, and a variety of assistive technologies. This requirement does not forbid or discourage providing mouse input or other input methods in addition to keyboard operation.
===== SCREEN CAPTURE =====
WCAG 2.1 Violation
No response
Reproduction/example
The scrollable element
The text was updated successfully, but these errors were encountered: