Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Add decorative icon option to Menu #14770

Closed
1 task done
laurenmrice opened this issue Oct 3, 2023 · 1 comment · Fixed by #14793
Closed
1 task done

[Feature Request]: Add decorative icon option to Menu #14770

laurenmrice opened this issue Oct 3, 2023 · 1 comment · Fixed by #14793
Labels
needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: dev 🤖 type: enhancement 💡

Comments

@laurenmrice
Copy link
Member

laurenmrice commented Oct 3, 2023 •
edited
Loading

The problem

Add decorative icon option to Menu

  • We need to have an option to display decorative icons in front of Menu label text.
    • Jan Hassel will help contribute the code implementation of the decorative icons Menu
menu with icons

The solution

The “Menu” component supports two functionalities
(Let’s call them "Full" and "Basic" for the sake of this example.)

  • Full: The menu can support nesting + selectable items, but can not support decorative icons.
  • Basic: The menu can supports decorative icons, but can not support nesting + selectable items.

The “parent” sets the mode

  • Menu (standalone, like when used with useContextMenu): Full
  • MenuButton: Basic
  • ComboButton: Basic
  • OverflowMenu: Full

Examples

menu with icons

Application/PAL

No response

Business priority

Medium to low priority. More of a nice to have

Code of Conduct
@laurenmrice laurenmrice added type: enhancement 💡 role: dev 🤖 proposal: open This request has gone through triaging. We're determining whether we take this on or not. labels Oct 3, 2023
@github-project-automation github-project-automation bot moved this to Triage in Roadmap Oct 3, 2023
@laurenmrice laurenmrice mentioned this issue Oct 3, 2023
Closed
@janhassel janhassel mentioned this issue Oct 5, 2023
Merged
@sstrubberg sstrubberg moved this from Triage to Ready for community implementation in Roadmap Oct 30, 2023
@sstrubberg sstrubberg added proposal: accepted This request has gone through triaging and we are accepting PR's against it. needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. and removed proposal: open This request has gone through triaging. We're determining whether we take this on or not. labels Oct 30, 2023
@github-actions
Copy link
Contributor

The Carbon team has accepted this proposal! Our team doesn't have the capacity to work on this now, so we are requesting community contributors. Please see the labels for roles that are needed. If you are willing to help out, comment below and we will get in touch!

@github-project-automation github-project-automation bot moved this from Ready for community implementation to Completed in Roadmap Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: dev 🤖 type: enhancement 💡
Projects
Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(menu): support menu modes janhassel/carbon
2 participants
@sstrubberg @laurenmrice