Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal: Tooltip is missing from the Close button on focus #14988

Closed
2 tasks done
thefirstartist opened this issue Oct 21, 2023 · 4 comments · Fixed by #15057
Closed
2 tasks done

Modal: Tooltip is missing from the Close button on focus #14988

thefirstartist opened this issue Oct 21, 2023 · 4 comments · Fixed by #15057
Labels
adopter: strategic-product Work-stream that directly effects the Product-led Growth initiative. component: modal component: tooltip needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: dev 🤖 type: a11y ♿ type: enhancement 💡

Comments

@thefirstartist
Copy link

thefirstartist commented Oct 21, 2023

Package

@carbon/react

Browser

Chrome

Operating System

MacOS

Package version

V10, V11

React version

v. 1.40

Automated testing tool and ruleset

n/a

Assistive technology

No response

Description

When navigating with keyboard on a modal, tooltip is missing from the 'Close' button on focus. Tooltip is required for non-text content.
image

Here's Carbon's accessibility guidance on buttons:
Icon-only buttons have their labels exposed automatically on hover and focus.
https://carbondesignsystem.com/components/button/accessibility#behavior
image

Also, when using a mouse to hover the 'Close' button, the tooltip is incorrect. (This is also covered in issue #14323)

image

WCAG 2.1 Violation

Success Criterion 1.1.1: Non-text Content

Reproduction/example

https://react.carbondesignsystem.com/?path=/story/components-modal--default&globals=theme:white

Steps to reproduce

The violation can be found in Carbon site or storybook.

Code of Conduct

@tw15egan
Copy link
Collaborator

Modal needs to be refactored to use IconButton so that it uses the correct Tooltip

@tw15egan tw15egan moved this to ⏱ Backlog in Design System Oct 23, 2023
@tay1orjones tay1orjones added type: enhancement 💡 proposal: accepted This request has gone through triaging and we are accepting PR's against it. labels Oct 24, 2023
@github-project-automation github-project-automation bot moved this to Triage in Roadmap Oct 24, 2023
@github-actions
Copy link
Contributor

Thank you for submitting a feature request. Your proposal is open and will soon be triaged by the Carbon team.

If your proposal is accepted and the Carbon team has bandwidth they will take on the issue, or else request you or other volunteers from the community to work on this issue.

@tay1orjones tay1orjones added adopter: DSAG adopter: strategic-product Work-stream that directly effects the Product-led Growth initiative. role: dev 🤖 labels Oct 24, 2023
@tay1orjones tay1orjones changed the title Tooltip is missing from the Close button on focus Modal: Tooltip is missing from the Close button on focus Oct 24, 2023
@sstrubberg sstrubberg moved this from Triage to Now in Roadmap Oct 30, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Carbon for AI Nov 8, 2023
@sstrubberg sstrubberg moved this to 🏗 In progress in Community Workgroups Nov 8, 2023
@sstrubberg sstrubberg added the needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. label Nov 8, 2023
Copy link
Contributor

github-actions bot commented Nov 8, 2023

The Carbon team has accepted this proposal! Our team doesn't have the capacity to work on this now, so we are requesting community contributors. Please see the labels for roles that are needed. If you are willing to help out, comment below and we will get in touch!

@thefirstartist
Copy link
Author

Just found out that the tooltip on the close button on notification is also missing.

image

@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Community Workgroups Jan 11, 2024
@github-project-automation github-project-automation bot moved this from Now to Completed in Roadmap Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adopter: strategic-product Work-stream that directly effects the Product-led Growth initiative. component: modal component: tooltip needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: dev 🤖 type: a11y ♿ type: enhancement 💡
Projects
Status: Done
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants