Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: warnings from SideNav in console log from inert prop #14990

Closed
2 tasks done
ecrvich opened this issue Oct 21, 2023 · 1 comment · Fixed by #15047
Closed
2 tasks done

[Bug]: warnings from SideNav in console log from inert prop #14990

ecrvich opened this issue Oct 21, 2023 · 1 comment · Fixed by #15047

Comments

@ecrvich
Copy link

ecrvich commented Oct 21, 2023

Package

@carbon/react

Browser

No response

Package version

1.40

React version

17 and 18 both show the warning

Description

I believe any usage of SideNav in one's app will produce this console warning now. Ren Maddox reported this 22 days ago in the Slack carbon-react channel (search for "inert"). Looks like Guilherme reproduced it in StackBlitz, but I don't believe he ever opened an Issue. I have removed the inert prop on the offending line in SideNav.js to keep my log from blowing up with this.

Warning: Received `false` for a non-boolean attribute `inert`.

If you want to write it to the DOM, pass a string instead: inert="false" or inert={value.toString()}.

If you used to conditionally omit it with inert={condition && value}, pass inert={condition ? value : undefined} instead.
    at nav
    at SideNavRenderFunction (c:\GitClones\CDD-Hub\node_modules\@carbon\react\lib\components\UIShell\SideNav.js:38:15)

Reproduction/example

see description

Steps to reproduce

see description

Suggested Severity

Severity 4 = Unrelated to a user task, has a workaround or does not need a workaround.

Application/PAL

No response

Code of Conduct

@kuri-sun
Copy link
Contributor

Hello,
I would like to work on this issue. May I?

@sstrubberg sstrubberg moved this to 🕵️‍♀️ Triage in Design System Nov 10, 2023
github-merge-queue bot pushed a commit that referenced this issue Nov 21, 2023
@github-project-automation github-project-automation bot moved this from 🕵️‍♀️ Triage to ✅ Done in Design System Nov 21, 2023
danoro96 pushed a commit to danoro96/carbon that referenced this issue Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants