-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request]: Add disableOverflow
option to PaginationNav to support high page counts
#15014
Comments
Thank you for submitting a feature request. Your proposal is open and will soon be triaged by the Carbon team. |
The performance issue is probably related to this bit of the code and could be rewritten to be more optimized for high page counts: carbon/packages/react/src/components/PaginationNav/PaginationNav.js Lines 302 to 318 in 7ef9cb9
Also note that Chrome limits the total amount of |
Connected to the UX in #15012 |
@tay1orjones I have mentioned that problem in the issue description:
If you would add a new property like |
@radarfox Yep, we just discussed as a team and agree, adding a This will fall lower on our list of priorities so we may not be able to get to it in a timely fashion. If you're keen to contribute this enhancement, we'd so appreciate it! I'm happy to answer any questions to help get you started on a PR, just let me know. |
disableOverflow
option to PaginationNav to support high page counts
The problem
We would like to migrate from our custom pagination component to PaginationNav. We have the publications catalogue, that has over 1600 pages. Our custom component has no problems navigating it, but as I'm trying the PaginationNav playground, it looks like it tends to freeze the browser just for thousands of pages. I'm using Chrome 118.
totalItems: 2500
will freeze my browser for about 5 seconds after the pagination is displayed.totalItems: 10000
will freeze my browser for about 45 seconds, during which Chrome warns twice that the page is not respondingThe solution
I'm not sure where exactly the problem is, so it's complicated to propose something. I suppose the problem might by in the select associated with "..." button. It lists thousands of items, which is a bit hard to navigate for the user. So, maybe allow to disable the select to prevent this? Or limit the select to some finite number of items? Maybe something like this:
Examples
https://research.ibm.com/publications
Application/PAL
https://research.ibm.com/
Business priority
Medium Priority = upcoming release but is not pressing
Available extra resources
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: