You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The PropType definition for 'aria-current' is to broad. it is currently defined as 'aria-current': PropTypes.oneOfType([PropTypes.string, PropTypes.bool]) however it will need to be modified to match AriaAttributes['aria-current']. This is causing issues with adding Typescript typings as well as the possibility of breaking if the user uses a specific type of and sets a non standard 'aria-current' value.
This does not show a break, however you can see that eslint is complaining that non standard strings can be used. There is a code path where the BreadcrumbItem can create a component and pass it the aria-current value. is already typed and only accepts the standard 'aria-current' values as shown below.
Suggested Severity
Severity 3 = User can complete task, and/or has a workaround within the user experience of a given component.
Package
@carbon/react
Browser
No response
Package version
v1.40.0
React version
No response
Description
The PropType definition for 'aria-current' is to broad. it is currently defined as
'aria-current': PropTypes.oneOfType([PropTypes.string, PropTypes.bool])
however it will need to be modified to matchAriaAttributes['aria-current']
. This is causing issues with adding Typescript typings as well as the possibility of breaking if the user uses a specific type of and sets a non standard 'aria-current' value.Reproduction/example
https://codesandbox.io/s/carbon-aria-current-f9lcrj?file=/src/App.js
Steps to reproduce
This does not show a break, however you can see that eslint is complaining that non standard strings can be used. There is a code path where the BreadcrumbItem can create a component and pass it the aria-current value. is already typed and only accepts the standard 'aria-current' values as shown below.
Suggested Severity
Severity 3 = User can complete task, and/or has a workaround within the user experience of a given component.
Application/PAL
Cloud
Code of Conduct
The text was updated successfully, but these errors were encountered: