Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C4AI Slug: Update callout in the Figma library to match what was built #15066

Closed
2 of 3 tasks
mattrosno opened this issue Oct 30, 2023 · 4 comments
Closed
2 of 3 tasks
Assignees
Labels
area: AI Used to filter issues in the Carbon for AI project. role: design ✏️

Comments

@mattrosno
Copy link
Member

mattrosno commented Oct 30, 2023

Tasks

Preview Give feedback
@mattrosno mattrosno converted this from a draft issue Oct 30, 2023
@mattrosno mattrosno added role: design ✏️ area: AI Used to filter issues in the Carbon for AI project. labels Oct 30, 2023
@mattrosno
Copy link
Member Author

@aagonzales can you add details and importance? I specified the Slug area in the project board, but did not add to the Slug styles and React epic, as this seems like something that can be done later (doesn't block the web components slug.)

@mattrosno mattrosno changed the title C4AI Slug: Update the callout's design spec to match what was implemented C4AI Slug: Update callout in the Figma library to match what was built Oct 30, 2023
@mattrosno
Copy link
Member Author

Anna:

The [callout] sharkfin wasn't originally included so we need to add it to the shared Figma library asset.

@mattrosno mattrosno moved this to 🕵️‍♀️ Triage in Design System Oct 31, 2023
@mattrosno mattrosno moved this from 🕵️‍♀️ Triage to 🪆 Needs Refined in Design System Oct 31, 2023
@mattrosno mattrosno moved this from 🪆 Needs Refined to ⏱ Backlog in Design System Oct 31, 2023
@mattrosno mattrosno added this to the Phase 1 - C4AI milestone Oct 31, 2023
@mattrosno mattrosno moved this from 🆕 New to 📋 Backlog in Carbon for AI Oct 31, 2023
@aagonzales
Copy link
Member

Data table updates:

AI slug moved beside the label to accommodate for the sort icon. Otherwise the slug sets 40px in from the right edge and looks like a bug.

image

Aura gradient only spans the header cell and not down the column due to technical difficulties. This may be readdress in the future but this is the MVP solution for phase 1.

image

@mattrosno mattrosno moved this from 📋 Backlog to 🏗 In progress in Carbon for AI Dec 4, 2023
@mattrosno mattrosno moved this from 🏗 In progress to 📋 Backlog in Carbon for AI Jan 29, 2024
@aagonzales
Copy link
Member

Closing this issue, in favor of a new kit issue that will combine the call and slug together in one component and include the slug.
carbon-design-system/carbon-design-kit#760

@github-project-automation github-project-automation bot moved this from ⏱ Backlog to ✅ Done in Design System Feb 15, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Carbon for AI Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: AI Used to filter issues in the Carbon for AI project. role: design ✏️
Projects
Status: ✅ Done
Archived in project
Development

No branches or pull requests

3 participants