Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive tag: final spec #15227

Closed
3 tasks done
Tracked by #13145
laurenmrice opened this issue Nov 17, 2023 · 4 comments
Closed
3 tasks done
Tracked by #13145

Interactive tag: final spec #15227

laurenmrice opened this issue Nov 17, 2023 · 4 comments
Assignees
Labels
adopter: PAL Work-stream that directly helps a Pattern & Asset Library. component: tags proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: design ✏️ type: enhancement 💡
Milestone

Comments

@laurenmrice
Copy link
Member

laurenmrice commented Nov 17, 2023

Acceptance criteria

Final spec

Copy link
Contributor

Thank you for submitting a feature request. Your proposal is open and will soon be triaged by the Carbon team.

If your proposal is accepted and the Carbon team has bandwidth they will take on the issue, or else request you or other volunteers from the community to work on this issue.

@laurenmrice laurenmrice added role: design ✏️ adopter: PAL Work-stream that directly helps a Pattern & Asset Library. labels Nov 17, 2023
@laurenmrice laurenmrice added this to the 2023 Q4 milestone Nov 17, 2023
@laurenmrice laurenmrice moved this to 🏗 In Progress in Design System Nov 17, 2023
@laurenmrice laurenmrice added the proposal: accepted This request has gone through triaging and we are accepting PR's against it. label Nov 17, 2023
@laurenmrice laurenmrice moved this to 🏗 In progress in Community Workgroups Nov 17, 2023
@laurenmrice laurenmrice moved this from 🏗 In Progress to 🚦 In Review in Design System Nov 20, 2023
@laurenmrice laurenmrice self-assigned this Nov 20, 2023
@laurenmrice
Copy link
Member Author

laurenmrice commented Dec 6, 2023

Feedback from playback

Icons in tags

  • Do not use a checkmark icon for the selected state in Selectable tags.
    • If needed we can always revisit this pattern for selection in the future if it is a crucial ask.
  • Do not use decorative icons in the Small size (18px) tag.
  • We have also seen teams, like Security, use status indicators inside of tags in cards, so this is another reason to advocate for icons in tags.

Focus states

  • Use the 2px thick stroke for the focus state with a 1px space between the tag and the focus border for all tag variants that receive focus. (*Except for Dismissable tag)
    • Helps create more breathing room for the Small tag size.
    • Helps differentiate between high contrast and outline tags.

Tag border colors

  • Selectable tag: high contrast border
  • Navigational tag: 40 border for light themes, 50 border for dark themes in all colors.
    • Remove high contrast and outline tag options from Navigational tag.

Active states

  • No active state for the Selectable or Navigational tags.


@laurenmrice
Copy link
Member Author

laurenmrice commented Dec 6, 2023

To dos

In context image examples

  • Create a couple use case examples per tag variant to make sure they are working properly within a real layout.

AI considerations

  • Do a quick mock of how the new variants would apply to AI situations to conclude they work well.

Enabled/Hover state visual differences between Selectable/Navigational tag

  • Providing a tooltip that says "View more" on the hover state for Navigational tag could help this problem. We could keep this as an optional prop
    • Gower question: Do we need to visually distinguish between the two more so users are better prepared to expect what will happen if they click on the tag. Could not be a huge deal, but nice to explore a scenario if possible.

Large 32px size tag

  • Confirm what the use cases are:
    • More screen real-estate at your disposal, usually used on a large page rather than in condensed or inline spaces.
    • Used when its more of the focal point of the page and primary task.
    • Larger click target area
    • Can be placed next to form components that are also 32px in height. We currently do not have 24px height form components other than Button.

Better name for "Navigational" tag?

  • Any other names that would be better? We do not want to encourage tags to be used as links to take you to new pages or launch new tabs. The term navigational could be misleading in that regard. Possible alternative names could be:
    • Operational tag
    • Actionable tag
    • View more tag
    • Details tag
    • Dynamic tag
    • Contextual tag
    • Structural tag

@laurenmrice laurenmrice moved this from 🚦 In Review to ✅ Done in Design System Jan 3, 2024
@sstrubberg sstrubberg moved this from Triage to Now in Roadmap Jan 6, 2024
@laurenmrice
Copy link
Member Author

laurenmrice commented Jan 8, 2024

Final Interactive tag designs

Selectable tag

Selectable tag

Operational tag

Operational tag

@github-project-automation github-project-automation bot moved this from Now to Completed in Roadmap Jan 8, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Community Workgroups Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adopter: PAL Work-stream that directly helps a Pattern & Asset Library. component: tags proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: design ✏️ type: enhancement 💡
Projects
Status: Done
Archived in project
Archived in project
Development

No branches or pull requests

1 participant