[Bug]: Dropdown itemToElement isn't working anymore (regression)

[janhassel]

Package

@carbon/react

Browser

Safari

Package version

1.49.0

React version

No response

Description

The Dropdown's itemToElement prop doesn't seem to be called anymore. Interestingly enough, itemToString can be used as a substitute for this (though based on the console outputs I don't think this is the intended use).

I couldn't find anything in the documentation or issues regarding a deprecation so I assume this is a regression?

Reproduction/example

https://stackblitz.com/edit/github-jxltcv?file=src%2FApp.jsx

Steps to reproduce

1. Pass a function to itemToElement: (item) => <em>{item.toLowerCase()}</em>
2. It's not used when rendering

itemToElement:

itemToString (results in expected result):

Suggested Severity

Severity 3 = User can complete task, and/or has a workaround within the user experience of a given component.

Application/PAL

No response

Code of Conduct

• I agree to follow this project's Code of Conduct
• I checked the current issues for duplicate problems

[guidari]

Hey @janhassel
itemToElement only work with objects. I was checking your example and the typeof is a string.

Here it is an Stackblitz example using an object.

Below you can check the logic in carbon:

 {typeof item === 'object' &&
    ItemToElement !== undefined &&
    ItemToElement !== null ? (
      <ItemToElement key={itemProps.id} {...item} />
    ) : (
      itemToString(item)
    )}

[janhassel]

@guidari Interesting, I didn't know that. So if I only have strings and need to display them as elements I need to wrap them in dummy objects, like { id: 'my-value' }?

Could you elaborate on the reasoning for this constraint?

[guidari]

@janhassel I'm not sure the reason behind that. I know that itemTostring is a props from Downshift and the itemToElement is a prop we created.