Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Callout] Implementation move to stable #15748

Open
Tracked by #15747
sstrubberg opened this issue Feb 13, 2024 · 1 comment
Open
Tracked by #15747

[Callout] Implementation move to stable #15748

sstrubberg opened this issue Feb 13, 2024 · 1 comment
Assignees
Milestone

Comments

@sstrubberg
Copy link
Member

sstrubberg commented Feb 13, 2024

Acceptance Criteria

Based on the design spec provided below in the REF issue, move Callout from Experimental to Production

REF #17083

relies on #18055

@sstrubberg sstrubberg changed the title [StaticNotification] Experimental->Production Implementation [StaticNotification] Implementation Feb 13, 2024
@sstrubberg sstrubberg moved this to ⏱ Backlog in Design System Feb 13, 2024
@sstrubberg sstrubberg moved this from ⏱ Backlog to 🪆 Needs Refined in Design System Feb 13, 2024
@sstrubberg sstrubberg added this to the 2024 Q2 milestone Feb 13, 2024
@tay1orjones tay1orjones changed the title [StaticNotification] Implementation [StaticNotification] Implementation move to stable Feb 26, 2024
@sstrubberg sstrubberg moved this from 🪆 Needs Refined to ⏱ Backlog in Design System Jun 19, 2024
@tay1orjones tay1orjones moved this from ⏱ Backlog to 🪆 Needs Refined in Design System Jun 27, 2024
@sstrubberg sstrubberg modified the milestones: 2024 Q2, 2024 Q3 Jun 27, 2024
@sstrubberg sstrubberg changed the title [StaticNotification] Implementation move to stable [Callout] Implementation move to stable Aug 14, 2024
@sstrubberg sstrubberg modified the milestones: 2024 Q3, 2024 Q4 Sep 16, 2024
@sstrubberg sstrubberg moved this from 🪆 Needs Refined to ⏱ Backlog in Design System Oct 2, 2024
@tay1orjones
Copy link
Member

tay1orjones commented Dec 4, 2024

Moving to stable

This list contains the criteria that need to be met to move this to stable:

  • All files have a copyright banner (do we still need this check, is it automatic?)
  • All components exported in src/index.js and should not be unstable_
    prefixed
  • Component has a label in the GitHub repository
  • Component should be documented on the website
    • Component should have a usage, style, and code tab
    • Component may have a component demo
  • For each component exported:
    • Component is written as a function declaration or uses forwardRef
    • Component has propTypes defined
      • Each prop type has a comment (used in storybook)
      • Prop types are as specific as needed, prefer PropTypes.shape over
        PropTypes.object if possible
    • Default props are listed as default args in the function definition (not
      in defaultProps)
      • Note: default props should be stable, in other words props like
        onClick = () => {} can cause re-renders since the function identity
        is not stable
    • Component has a story in <ComponentName>.stories.js
      • Component has an mdx document that follows our outline
      • mdx document coverages at least common use-cases and provides a prop
        table
      • Stories cover at least common use-cases
      • Stories may include a Playground story for controls
        • Controls with no meaningful change to the component visuals should
          be hidden from the controls panel, eg. className
        • Props of type node with no proper controls available for
          configuration should be hidden from the controls panel, eg.
          children
      • Stories should mirror intended usage of the component
    • Component has unit/integration tests written in RTL for testing the
      component API
    • Component is tested via VRT for at least the initial render state
    • Component is tested via AVT for at least the initial render state

@tay1orjones tay1orjones self-assigned this Dec 4, 2024
@sstrubberg sstrubberg modified the milestones: 2024 Q4, 2025 Q1 Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ⏱ Backlog
Development

No branches or pull requests

2 participants