Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a11y]: The ARIA attributes "aria-labelledby" are not valid for the element <div> with implicit ARIA role "generic" #15785

Closed
2 tasks done
molyholy opened this issue Feb 19, 2024 · 4 comments
Labels
severity: 3 https://ibm.biz/carbon-severity status: waiting for maintainer response 💬 type: a11y ♿ version: 10 Issues pertaining to Carbon v10

Comments

@molyholy
Copy link

Package

carbon-components-react

Browser

Firefox

Operating System

MacOS

Package version

v10 (which I think is the version PAL is using)

React version

No response

Automated testing tool and ruleset

IBM Accessbility Checker

Assistive technology

No response

Description

This a11y issue was flagged in a Modal used in one of my repos, however after running the IBM a11y checker on the Modal docs, it seems the issue just exists in the original Modal code too

WCAG 2.1 Violation

No response

Reproduction/example

https://v10.carbondesignsystem.com/components/modal/code/

Steps to reproduce

  1. Go to https://v10.carbondesignsystem.com/components/modal/code/
  2. Open the Modal in the code example
  3. Run the IBM a11y checker
  4. Observe this error
    image

Code of Conduct

@sstrubberg
Copy link
Member

This needs severity

@molyholy
Copy link
Author

molyholy commented Mar 19, 2024

A field for severity doesn't seem to be in the "accessibility issue" template like how there's one in the "bug report" template

but in this case the severity is low

@sstrubberg
Copy link
Member

A field for severity doesn't seem to be in the "accessibility issue" template like how there's one in the "bug report" template

but in this case the severity is low

Thanks for the feedback @molyholy. I should have been more clarifying when I posted. I was looking for @carbon-design-system/developers to weigh in and assign priority when triaging this issue.

@sstrubberg sstrubberg removed the status in Design System Mar 28, 2024
@sstrubberg sstrubberg moved this to 🕵️‍♀️ Triage in Design System Mar 28, 2024
@guidari guidari added the severity: 3 https://ibm.biz/carbon-severity label Apr 1, 2024
@tw15egan
Copy link
Collaborator

tw15egan commented Apr 3, 2024

This seems like a v10 website-specific issue, most likely due to an out-of-date carbon-components-react version. I cannot reproduce the violation checking the Modal in the v10 storybook running the latest version of V10, so I suggest trying to upgrade to 7.59.21 and seeing if your issue is resolved.

Update: Looks like this was fixed via #14170 and should be included in any version later than 7.59.10

@tw15egan tw15egan closed this as completed Apr 3, 2024
@github-project-automation github-project-automation bot moved this from 🕵️‍♀️ Triage to ✅ Done in Design System Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity: 3 https://ibm.biz/carbon-severity status: waiting for maintainer response 💬 type: a11y ♿ version: 10 Issues pertaining to Carbon v10
Projects
Archived in project
Development

No branches or pull requests

4 participants