-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tag ellipses with Tooltip #15959
Tag ellipses with Tooltip #15959
Conversation
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great Gui! Just a couple comments:
Tag (Stable)
Playground story
Can we show one tag here with a normal tag title length instead of the ellipsis tag? I think it’s good to show the ellipsis tag in the Read Only story like you are showing, but I think we should just show a normal tag with a desired tag title length in the Playground story.
Tag (Experimental)
Dismissible story
The dismissible tag in the small size has a misaligned close icon for most of the colors.
I have mild concerns with making a read-only tag become interactive simply to expose the tip. How is a user to understand that is the intent, especially where the tag itself is taking focus? Here are a few other possibilities...
Benefits:
Note that it might scale better to have the phrase preceding the ellipsis be part of the definition tooltip too. That would also provide more context for accessibility (i.e. three seemingly identical ellipses on one page would instead be three different definition links that might be called 'Info about a...', 'Info about b...', 'Info about c...') |
Thanks Michael for these other possibilities! I am going to share these at tomorrows design crit so we can come to a common solution for the tag overflow. I have asked Gui and Taylor to join as well if they can. |
Note that the proposed use of a tooltip on an operable variation of tag which also happen to be truncated seems like it should work fine; it's just when the tag is not operable that I see the main issue. |
Going to mark this as a draft since we're waiting on a final revisited design spec which should be complete soon |
Just wanted to note here that the design spec has been updated and reflected in the issue last week. 👍 |
NEW PR #16437 |
Closes #15893
This PR will add the ellipses to tags that have a long text. When the ellipses is active the Tooltip will added so the user can read the whole tag
Changelog
New
max-inline-size
to tags of 208px.text
to Interactive tags. That way we can keep the ellipses logic in the primitiveTag
only.Removed
children
prop from interactive tags.Testing / Reviewing
text
make sense