Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Should Radio button fix has been released? #15992

Open
1 task done
BenceLovas opened this issue Mar 18, 2024 · 5 comments
Open
1 task done

[Bug]: Should Radio button fix has been released? #15992

BenceLovas opened this issue Mar 18, 2024 · 5 comments

Comments

@BenceLovas
Copy link

Question for Carbon

Hi,
I've opened an issue about the radio button component. #15894
It has been fixed, and based on the commit history, it should have been released in 1.53.0, but neither I can see it in the release notes, nor it works when I update the library. I might guessed it wrong by assuming that every commit gets released.
So, has it been released?

Code of Conduct

@tay1orjones
Copy link
Member

@BenceLovas Based on the info on the page for the merge commit, that commit was first made available in v1.53.0-rc.0. This means it was also included in everything after: 1.53.0, and the patch we just cut, 1.53.1.

image

Viewing the published package on unpkg I can see that it's there (search for print-color-adjust)

Could you reproduce the issue in a stackblitz showing how it's not working, and post the link back here? It's hard to know exactly what's going wrong without seeing the issue firsthand.

@tay1orjones tay1orjones added the status: needs reproduction Issues lacking a code reproduction label Mar 19, 2024
@BenceLovas
Copy link
Author

BenceLovas commented Mar 20, 2024

@tay1orjones My original issue was about the Radio Button component, but it also has the print-color-adjust added to the scss file.

The issue was (and still is) that the selected radio button has not been shown on the print preview (⌘ Command + P), hence the saved pdf won't have it either. (I'm not sure if this applies to the Checkbox component as well, haven't tested that.)

Reproduction: https://codesandbox.io/p/devbox/goofy-liskov-2ljg99?file=%2Fsrc%2FExample%2FExample.jsx%3A11%2C19
If you open print preview (it's a bit cluttered in this case), you can see that the radio button selection is not reflected (all circles are empty).

@tay1orjones
Copy link
Member

It looks like that's isolated to the codesandbox environment. They're showing in the story

image

@BenceLovas
Copy link
Author

@tay1orjones It's weird, you're right it's showing up on your Storybook, but I tried it on Stackblitz as well and it was not woking: https://stackblitz.com/edit/vitejs-vite-6byqqw?file=src%2FApp.scss,src%2FApp.jsx&terminal=dev
I also tried it in two separate React projects and it wasn't working either.
Can it be that your Storybook example is somehow differs from what I was reproducing?

@sstrubberg sstrubberg moved this to 🕵️‍♀️ Triage in Design System Mar 28, 2024
@guidari
Copy link
Contributor

guidari commented Apr 1, 2024

Yeah. And it is only happening in Chrome. I tested on FF and Safari and it works as expected

@guidari guidari moved this from 🕵️‍♀️ Triage to ⏱ Backlog in Design System Apr 1, 2024
@sstrubberg sstrubberg changed the title [Question]: Should Radio button fix has been released? [Bug]: Should Radio button fix has been released? Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ⏱ Backlog
Development

No branches or pull requests

4 participants