Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: <Tag type=outline /> background-color is incorrect on Layer 1/2/3 #16189

Open
2 tasks done
justindm234 opened this issue Apr 12, 2024 · 3 comments
Open
2 tasks done

Comments

@justindm234
Copy link

justindm234 commented Apr 12, 2024

Package

@carbon/react

Browser

Chrome

Package version

1.55.0

React version

18.2.0

Description

When rendered on Layer 1, 2, or 3, the background color of a Tag with type=outline is incorrect. The background color is --cds-background instead of --cds-layer.

Reproduction/example

https://stackblitz.com/edit/github-srfy1t-qa1mdh?file=src%2FApp.jsx

image

Steps to reproduce

Render a Tag with type=outline on layer 1, 2, or 3

Suggested Severity

Severity 3 = User can complete task, and/or has a workaround within the user experience of a given component.

Application/PAL

IBM Z Hardware Management Console

Code of Conduct

@tay1orjones
Copy link
Member

I'm not sure if this is intentional or not. @carbon-design-system/design could you weigh in?

@laurenmrice
Copy link
Member

laurenmrice commented Apr 16, 2024

Recently we have been doing a lot of work on revamping our tag component and adding new variants. I am thinking we should change the enabled background color to be transparent if it is being used on$background in some cases, and being used on different $layer sets. I actually did expect the outline tag to have a "hollow" background effect.

Using transparent as the background for outline tag, will also help differentiate it from a Selectable tag variant which was recently added to the system and uses $layer. I will create a spec exploration to make sure this works correctly.

  • Create design spec

@tay1orjones tay1orjones moved this from 🕵️‍♀️ Triage to ⏱ Backlog in Design System Apr 29, 2024
@laurenmrice laurenmrice added this to the 2024 Q3 milestone May 30, 2024
@sstrubberg sstrubberg added the severity: 3 https://ibm.biz/carbon-severity label Jul 11, 2024
@sstrubberg sstrubberg removed this from the 2024 Q3 milestone Jul 11, 2024
@RaghavRR
Copy link

RaghavRR commented Jan 8, 2025

Hello! If this issue is still open, I would love to contribute to solving it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ⏱ Backlog
Development

No branches or pull requests

5 participants