Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dropdown: Combobox & Multiselect]: Fixing focus state dev implementation #16512

Closed
1 of 4 tasks
Tracked by #6102
Kritvi-bhatia17 opened this issue May 20, 2024 · 1 comment · Fixed by #16789
Closed
1 of 4 tasks
Tracked by #6102

[Dropdown: Combobox & Multiselect]: Fixing focus state dev implementation #16512

Kritvi-bhatia17 opened this issue May 20, 2024 · 1 comment · Fixed by #16789
Assignees
Milestone

Comments

@Kritvi-bhatia17
Copy link
Contributor

Kritvi-bhatia17 commented May 20, 2024

The problem

  1. After sharing at the CAG call, we will not be putting focus on the first option in the open menu in Figma if nothing is selected.
  2. Check whether the focus state is overlapping correctly when both the parent and child items have focus states. The overlapping focus stroke should be 2 px.

The solution

  1. Removing the focus state from:
    • Combobox
    • Multi-select
    • Filterable multi-select

Examples

Ref: Figma kit

Application/PAL

No response

Business priority

None

Available extra resources

No response

Code of Conduct

Copy link
Contributor

Thank you for submitting a feature request. Your proposal is open and will soon be triaged by the Carbon team.

If your proposal is accepted and the Carbon team has bandwidth they will take on the issue, or else request you or other volunteers from the community to work on this issue.

@Kritvi-bhatia17 Kritvi-bhatia17 changed the title [Dropdown] Fixing the focus state [Dropdown: Combobox & Multi-select] Fixing the focus state May 20, 2024
@laurenmrice laurenmrice changed the title [Dropdown: Combobox & Multi-select] Fixing the focus state [Dropdown: Combobox & Multiselect]: Fixing focus state dev implementation Jun 12, 2024
@guidari guidari self-assigned this Jun 13, 2024
@guidari guidari moved this to ⏱ Backlog in Design System Jun 13, 2024
@tay1orjones tay1orjones moved this from ⏱ Backlog to 🚦 In Review in Design System Jun 19, 2024
@sstrubberg sstrubberg moved this from Triage to Now in Roadmap Jun 27, 2024
@sstrubberg sstrubberg modified the milestones: 2024 Q2, 2024 Q3 Jun 27, 2024
@github-project-automation github-project-automation bot moved this from 🚦 In Review to ✅ Done in Design System Aug 6, 2024
@github-project-automation github-project-automation bot moved this from Now to Completed in Roadmap Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants