-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(icons-react): update svg code to remove breaking style attribute #16736
Conversation
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@tay1orjones I'm not sure how we test for this, this is the issue in the generated code for the two icons above. the style prop should be an object, not a string like it was being generated. Seems like it was related to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can track this issue on the next realease for carbon-website
to test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting - yeah I'm not sure how or if we should test for it. Great idea to test it on the website
8330078
Closes carbon-design-system/carbon-website#4096
Changelog
isolation: isolate;
Testing / Reviewing
Icons should look visually identical