Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test]: Add tests related to selectedItems for MultiSelect #16828

Closed
Gururajj77 opened this issue Jun 20, 2024 · 0 comments · Fixed by #16838
Closed

[Test]: Add tests related to selectedItems for MultiSelect #16828

Gururajj77 opened this issue Jun 20, 2024 · 0 comments · Fixed by #16838
Assignees
@Gururajj77
Labels
component: multiselect role: dev 🤖 status: needs tests PRs that need tests

Comments

@Gururajj77
Copy link
Contributor

Gururajj77 commented Jun 20, 2024 •
edited
Loading

Description

As we had faced issues like #16716 and #16469, the crux of these issues seems to be like we have no tests covered the controlled state, the selectedItems prop. Will need some test suites to cover these, so that if any code commit happens on these there will be tests to catch them if they break.
@Gururajj77 Gururajj77 self-assigned this Jun 20, 2024
@Gururajj77 Gururajj77 moved this to 🏗 In Progress in Design System Jun 20, 2024
@Gururajj77 Gururajj77 mentioned this issue Jun 21, 2024
Merged
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in Design System Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gururajj77 Gururajj77

Labels
component: multiselect role: dev 🤖 status: needs tests PRs that need tests
Projects
Design System
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tests: Added test suite to check the selectedItems prop from external state Gururajj77/carbon
1 participant
@Gururajj77