-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: FilterableMultiSelect onMenuChange not called on click outside menu #16896
Closed
2 tasks done
Labels
component: filterable-multiselect
role: dev 🤖
severity: 3
https://ibm.biz/carbon-severity
type: bug 🐛
Comments
Hi @gi , could you please let us know the steps to reproduce this issue, by making a stackblitz example so that we can work on this issue better and resolve it. Please use sandboxes from this carbon sandbox repo, they are already customized with carbon library |
Hey @Gururajj77 I'm facing the same issue, any idea when this will be fixed? Is currently blocking us from upgrading Carbon due to this bug. Thanks! |
Gururajj77
added
severity: 3
https://ibm.biz/carbon-severity
role: dev 🤖
and removed
status: needs triage 🕵️♀️
status: waiting for maintainer response 💬
status: needs reproduction
Issues lacking a code reproduction
labels
Jul 25, 2024
gi
added a commit
to gi/carbon-ui
that referenced
this issue
Aug 9, 2024
This fixes an issue where a mouse click event outside of the menu does not call the `onMenuChange` callback when the menu is open. Fixes carbon-design-system#16896
github-merge-queue bot
pushed a commit
that referenced
this issue
Sep 12, 2024
#17136) * fix(FilterableMultiSelect): call onMenuChange when mouse click outside This fixes an issue where a mouse click event outside of the menu does not call the `onMenuChange` callback when the menu is open. Fixes #16896 * docs(FilterableMultiSelect): add story action for `onMenuChange` This adds an action recorder for `onMenuChange` in storybook. --------- Co-authored-by: Taylor Jones <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: filterable-multiselect
role: dev 🤖
severity: 3
https://ibm.biz/carbon-severity
type: bug 🐛
Package
@carbon/react
Browser
Chrome
Package version
1.57.0
React version
v16.14.0
Description
When clicking outside the menu when opened, the onMenuChange callback is not fired with the next opened state.
The change came between
de133bea
and
5f35edd6
when
FilterableMultiSelect.js
was renamed toFilterableMultiSelect.tsx
.The
Downshift
component had anonOuterClick
prop set tohandleOnOuterClick
which calledhandleOnMenuChange
.Reproduction/example
https://stackblitz.com/edit/github-wivrwb?file=src%2FApp.jsx&preset=node=
Steps to reproduce
onMenuChange
prop onFilterableMultiSelect
componentonMenuChange
callback is not calledSuggested Severity
Severity 2 = User cannot complete task, and/or no workaround within the user experience of a given component.
Application/PAL
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: