Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: The subtitle prop should be node type rather than string type #16909

Closed
2 tasks done
flannanl opened this issue Jul 3, 2024 · 1 comment
Closed
2 tasks done

Comments

@flannanl
Copy link

flannanl commented Jul 3, 2024

Package

@carbon/react

Browser

No response

Package version

v1.53.1

React version

v17.0.2

Description

The subtitle prop in InlineNotification in Carbon 11 is now a string type. In Carbon 10, the prop is a node type. This creates React warning all over the places when we upgrade from Carbon 10 to 11. Can you change the subtitle prop back to a node type?

Reproduction/example

N/A

Steps to reproduce

Here is an example of my code snippet:

                    <InlineNotification
                      kind="error"
                      role="alert"
                      lowContrast
                      hideCloseButton
                      title={t('Failed to fetch')}
                      subtitle={
                        <>
                          {t(
                            'An error occurred when fetching secrets. Try again later.'
                          )}
                          {errorGuid && (
                            <span className="cpc--secret-input__error-guid">{` (${errorGuid})`}</span>
                          )}
                        </>
                      }
                    />

Suggested Severity

None

Application/PAL

No response

Code of Conduct

@tay1orjones
Copy link
Member

Closing based on the rationale explained in #16911 (review)

@tay1orjones tay1orjones closed this as not planned Won't fix, can't repro, duplicate, stale Jul 17, 2024
@github-project-automation github-project-automation bot moved this from ⏱ Backlog to ✅ Done in Design System Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
3 participants